Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: third_party/WebKit/Source/web/ExternalPopupMenu.cpp

Issue 2589493003: Specify TaskType of posted Task explicitly in popup UIs (8) (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 14 matching lines...) Expand all
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "web/ExternalPopupMenu.h" 31 #include "web/ExternalPopupMenu.h"
32 32
33 #include "core/dom/ExecutionContextTask.h" 33 #include "core/dom/ExecutionContextTask.h"
34 #include "core/dom/NodeComputedStyle.h" 34 #include "core/dom/NodeComputedStyle.h"
35 #include "core/dom/TaskRunnerHelper.h"
35 #include "core/frame/FrameHost.h" 36 #include "core/frame/FrameHost.h"
36 #include "core/frame/FrameView.h" 37 #include "core/frame/FrameView.h"
37 #include "core/frame/LocalFrame.h" 38 #include "core/frame/LocalFrame.h"
38 #include "core/html/HTMLOptionElement.h" 39 #include "core/html/HTMLOptionElement.h"
39 #include "core/html/HTMLSelectElement.h" 40 #include "core/html/HTMLSelectElement.h"
40 #include "core/layout/LayoutBox.h" 41 #include "core/layout/LayoutBox.h"
41 #include "core/page/Page.h" 42 #include "core/page/Page.h"
42 #include "core/style/ComputedStyle.h" 43 #include "core/style/ComputedStyle.h"
43 #include "platform/geometry/FloatQuad.h" 44 #include "platform/geometry/FloatQuad.h"
44 #include "platform/geometry/IntPoint.h" 45 #include "platform/geometry/IntPoint.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 } 140 }
140 141
141 void ExternalPopupMenu::updateFromElement(UpdateReason reason) { 142 void ExternalPopupMenu::updateFromElement(UpdateReason reason) {
142 switch (reason) { 143 switch (reason) {
143 case BySelectionChange: 144 case BySelectionChange:
144 case ByDOMChange: 145 case ByDOMChange:
145 if (m_needsUpdate) 146 if (m_needsUpdate)
146 return; 147 return;
147 m_needsUpdate = true; 148 m_needsUpdate = true;
148 m_ownerElement->document().postTask( 149 m_ownerElement->document().postTask(
149 BLINK_FROM_HERE, createSameThreadTask(&ExternalPopupMenu::update, 150 TaskType::UserInteraction, BLINK_FROM_HERE,
150 wrapPersistent(this))); 151 createSameThreadTask(&ExternalPopupMenu::update,
152 wrapPersistent(this)));
151 break; 153 break;
152 154
153 case ByStyleChange: 155 case ByStyleChange:
154 // TOOD(tkent): We should update the popup location/content in some 156 // TOOD(tkent): We should update the popup location/content in some
155 // cases. e.g. Updating ComputedStyle of the SELECT element affects 157 // cases. e.g. Updating ComputedStyle of the SELECT element affects
156 // popup position and OPTION style. 158 // popup position and OPTION style.
157 break; 159 break;
158 } 160 }
159 } 161 }
160 162
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 if (ownerElement.itemIsDisplayNone(*items[i])) 301 if (ownerElement.itemIsDisplayNone(*items[i]))
300 continue; 302 continue;
301 if (popupMenuItemIndex == i) 303 if (popupMenuItemIndex == i)
302 return indexTracker; 304 return indexTracker;
303 ++indexTracker; 305 ++indexTracker;
304 } 306 }
305 return -1; 307 return -1;
306 } 308 }
307 309
308 } // namespace blink 310 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/notifications/Notification.cpp ('k') | third_party/WebKit/Source/web/PopupMenuImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698