Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: src/compiler/escape-analysis.cc

Issue 2589163002: [turbofan] reenable escape analysis to further investigate crashes (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/escape-analysis.cc
diff --git a/src/compiler/escape-analysis.cc b/src/compiler/escape-analysis.cc
index 95c06797603ead1144f785e2f87d592fee3dc08a..a61d90ebaffaf420badacca655bef582d9e2d1a9 100644
--- a/src/compiler/escape-analysis.cc
+++ b/src/compiler/escape-analysis.cc
@@ -441,6 +441,15 @@ bool VirtualObject::MergeFields(size_t i, Node* at, MergeCache* cache,
Node* rep = GetField(i);
if (!rep || !IsCreatedPhi(i)) {
Node* control = NodeProperties::GetControlInput(at);
+
+ // Check to debug canary.
+ CHECK_NOT_NULL(control);
+ CHECK(!control->IsDead());
+ for (Node* input : cache->fields()) {
+ CHECK_NOT_NULL(input);
+ CHECK(!input->IsDead());
+ }
+
cache->fields().push_back(control);
Node* phi = graph->NewNode(
common->Phi(MachineRepresentation::kTagged, value_input_count),
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698