Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2178)

Unified Diff: third_party/WebKit/Source/build/scripts/name_utilities.py

Issue 2589143003: Add 'get' prefix for Settings.in generated code. (Closed)
Patch Set: Only get prefix and no capitalization. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/name_utilities.py
diff --git a/third_party/WebKit/Source/build/scripts/name_utilities.py b/third_party/WebKit/Source/build/scripts/name_utilities.py
index f6fb2790cb5f8370216d90466cb19d04f15abd09..90b80ba8cc3f0b05d588a69e89144e8a7c79ca93 100644
--- a/third_party/WebKit/Source/build/scripts/name_utilities.py
+++ b/third_party/WebKit/Source/build/scripts/name_utilities.py
@@ -59,10 +59,13 @@ def lower_first(name):
def upper_first(name):
- """Return name with first letter or initial acronym uppercased."""
+ """Return name with first letter or initial acronym uppercased.
+ The acronym must have a capital letter following it to be considered.
+ """
for acronym in ACRONYMS:
if name.startswith(acronym.lower()):
- return name.replace(acronym.lower(), acronym, 1)
+ if len(name) == len(acronym) or name[len(acronym)].isupper():
+ return name.replace(acronym.lower(), acronym, 1)
return upper_first_letter(name)

Powered by Google App Engine
This is Rietveld 408576698