third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl - Issue 2589143003: Add 'get' prefix for Settings.in generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl

Issue 2589143003: Add 'get' prefix for Settings.in generated code. (Closed)

Patch Set: Only get prefix and no capitalization. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/name_utilities.py ('k') | third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl

index 7e17d48d79379031c015879be4833a597a0fdcd3..5eb67dfdd737a5b3570214270a8baedbd2ccdfbc 100644

--- a/third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl

@@ -11,7 +11,7 @@ namespace blink {

InternalSettingsGenerated::InternalSettingsGenerated(Page* page)

: m_page(page)

{% for setting in settings if setting.type|to_idl_type %}

- , m_{{setting.name}}(page->settings().{{setting.name}}())

+ , m_{{setting.name}}(page->settings().get{{setting.name|upper_first}}())

{% endfor %}

{

}