third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp - Issue 2589143003: Add 'get' prefix for Settings.in generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

Issue 2589143003: Add 'get' prefix for Settings.in generated code. (Closed)

Patch Set: Only get prefix and no capitalization. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

index 3c29ed9a153bea4f5db514545c2deffcd58a20fa..65f0f9f7eb5d088be74492f2855c6c1c16bd751f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

@@ -615,7 +615,7 @@ bool ScriptStreamer::startStreamingInternal(PendingScript* script,

// produce parser cache if the non-streaming compile takes advantage of it.

v8::ScriptCompiler::CompileOptions compileOption =

v8::ScriptCompiler::kNoCompileOptions;

- if (settings->v8CacheOptions() == V8CacheOptionsParse)

+ if (settings->getV8CacheOptions() == V8CacheOptionsParse)

compileOption = v8::ScriptCompiler::kProduceParserCache;

// The Resource might go out of scope if the script is no longer