Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2589063002: s390: clean up RR/RRE/RRD/RIL format in Assembler (Closed)

Created:
4 years ago by john.yan
Modified:
4 years ago
Reviewers:
JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: clean up RR/RRE/RRD/RIL format in Assembler R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2589063002 Cr-Commit-Position: refs/heads/master@{#41864} Committed: https://chromium.googlesource.com/v8/v8/+/2d7f1c2c55598ed2d351f1dcc18387a15b3d669f

Patch Set 1 #

Patch Set 2 : remove comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -685 lines) Patch
M src/full-codegen/s390/full-codegen-s390.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ic/s390/ic-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/s390/assembler-s390.h View 12 chunks +157 lines, -140 lines 0 comments Download
M src/s390/assembler-s390.cc View 1 43 chunks +6 lines, -534 lines 0 comments Download
M src/s390/constants-s390.h View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
john.yan
ptal
4 years ago (2016-12-20 05:55:19 UTC) #1
JaideepBajwa
lgtm
4 years ago (2016-12-20 12:56:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589063002/20001
4 years ago (2016-12-20 14:35:38 UTC) #4
commit-bot: I haz the power
4 years ago (2016-12-20 15:03:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2d7f1c2c55598ed2d351f1dcc18387a15b3...

Powered by Google App Engine
This is Rietveld 408576698