Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2589013002: [Android] Show keyword instead of parsed url for each custom engine (Closed)

Created:
4 years ago by ltian
Modified:
4 years ago
Reviewers:
Peter Kasting, gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Show keyword instead of parsed url for each custom engine Currently Android displays "xxx.com" parsed from url of a TemplateURL. This is not appropriate because url could ends with different types of domains such as ".org", ".co" and etc. And also this is inconsitent with information shown on desktop. To solve this, the field will be displayed with the keyword of a TemplateURL. BUG=675738 Committed: https://crrev.com/a0fdaeac4fcfad4d00ba10e10826ee375164e8db Cr-Commit-Position: refs/heads/master@{#440314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java View 3 chunks +3 lines, -13 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_android.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
ltian
dfalcantara@chromium.org: can you take a look of the changes on Java codes? Thanks!
4 years ago (2016-12-20 19:47:12 UTC) #6
gone
lgtm
4 years ago (2016-12-21 00:01:25 UTC) #7
ltian
pkasting@chromium.org: can you review changes in template_url_service_android.cc? Thanks!
4 years ago (2016-12-21 23:28:45 UTC) #9
Peter Kasting
LGTM
4 years ago (2016-12-22 00:04:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589013002/1
4 years ago (2016-12-22 01:42:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 02:16:43 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-22 02:19:40 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0fdaeac4fcfad4d00ba10e10826ee375164e8db
Cr-Commit-Position: refs/heads/master@{#440314}

Powered by Google App Engine
This is Rietveld 408576698