Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3030)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

Issue 2589013002: [Android] Show keyword instead of parsed url for each custom engine (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java b/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
index 5af07f101e96d8d5475ce20eb19b638fa400d583..e6f0c33aeae56be4fd1de999c16b3e5c51c621b4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
@@ -15,8 +15,6 @@ import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.util.ArrayList;
import java.util.List;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
/**
* Android wrapper of the TemplateUrlService which provides access from the Java
@@ -63,24 +61,20 @@ public class TemplateUrlService {
public static class TemplateUrl {
private final int mIndex;
private final String mShortName;
- private final String mUrl;
private final boolean mIsPrepopulated;
private final String mKeyword;
@TemplateUrlType private int mTemplateUrlType;
@CalledByNative("TemplateUrl")
public static TemplateUrl create(
- int id, String shortName, String url, boolean isPrepopulated, String keyword) {
- return new TemplateUrl(id, shortName, url, isPrepopulated, keyword);
+ int id, String shortName, boolean isPrepopulated, String keyword) {
+ return new TemplateUrl(id, shortName, isPrepopulated, keyword);
}
public TemplateUrl(
- int index, String shortName, String url, boolean isPrepopulated, String keyword) {
+ int index, String shortName, boolean isPrepopulated, String keyword) {
mIndex = index;
mShortName = shortName;
- Pattern pattern = Pattern.compile("[^/]+.com");
- Matcher m = pattern.matcher(url);
- mUrl = m.find() ? m.group(0) : "";
mIsPrepopulated = isPrepopulated;
mKeyword = keyword;
}
@@ -93,10 +87,6 @@ public class TemplateUrlService {
return mShortName;
}
- public String getUrl() {
- return mUrl;
- }
-
public boolean getIsPrepopulated() {
return mIsPrepopulated;
}

Powered by Google App Engine
This is Rietveld 408576698