Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2588973003: Revert of [profiler] Add extra CHECK to track down crbug.com/665398 (Closed)

Created:
4 years ago by alph
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [profiler] Add extra CHECK to track down crbug.com/665398 (patchset #1 id:1 of https://codereview.chromium.org/2556833003/ ) Reason for revert: Not needed anymore. The bug is fixed. Original issue's description: > [profiler] Add extra CHECK to track down crbug.com/665398 > > BUG=chromium:665398 > > Committed: https://crrev.com/dfc0bb63a1bc115d39f29cfc338aed5676578c4b > Cr-Commit-Position: refs/heads/master@{#41545} TBR=yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:665398 Review-Url: https://codereview.chromium.org/2588973003 Cr-Commit-Position: refs/heads/master@{#41830} Committed: https://chromium.googlesource.com/v8/v8/+/f2281ac7cd238cf54907eb2989646fece11581cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M src/profiler/profile-generator.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/profiler/profile-generator-inl.h View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
alph
Created Revert of [profiler] Add extra CHECK to track down crbug.com/665398
4 years ago (2016-12-20 02:01:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588973003/1
4 years ago (2016-12-20 02:01:29 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-20 02:28:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f2281ac7cd238cf54907eb2989646fece11...

Powered by Google App Engine
This is Rietveld 408576698