Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: src/profiler/profile-generator-inl.h

Issue 2588973003: Revert of [profiler] Add extra CHECK to track down crbug.com/665398 (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/profiler/profile-generator.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PROFILER_PROFILE_GENERATOR_INL_H_ 5 #ifndef V8_PROFILER_PROFILE_GENERATOR_INL_H_
6 #define V8_PROFILER_PROFILE_GENERATOR_INL_H_ 6 #define V8_PROFILER_PROFILE_GENERATOR_INL_H_
7 7
8 #include "src/profiler/profile-generator.h" 8 #include "src/profiler/profile-generator.h"
9 9
10 namespace v8 { 10 namespace v8 {
11 namespace internal { 11 namespace internal {
12 12
13 CodeEntry::CodeEntry(CodeEventListener::LogEventsAndTags tag, const char* name, 13 CodeEntry::CodeEntry(CodeEventListener::LogEventsAndTags tag, const char* name,
14 const char* name_prefix, const char* resource_name, 14 const char* name_prefix, const char* resource_name,
15 int line_number, int column_number, 15 int line_number, int column_number,
16 JITLineInfoTable* line_info, Address instruction_start) 16 JITLineInfoTable* line_info, Address instruction_start)
17 : bit_field_(TagField::encode(tag) | 17 : bit_field_(TagField::encode(tag) |
18 BuiltinIdField::encode(Builtins::builtin_count)), 18 BuiltinIdField::encode(Builtins::builtin_count)),
19 name_prefix_(name_prefix), 19 name_prefix_(name_prefix),
20 name_(name), 20 name_(name),
21 resource_name_(resource_name), 21 resource_name_(resource_name),
22 line_number_(line_number), 22 line_number_(line_number),
23 column_number_(column_number), 23 column_number_(column_number),
24 script_id_(v8::UnboundScript::kNoScriptId), 24 script_id_(v8::UnboundScript::kNoScriptId),
25 position_(0), 25 position_(0),
26 bailout_reason_(kEmptyBailoutReason), 26 bailout_reason_(kEmptyBailoutReason),
27 deopt_reason_(kNoDeoptReason), 27 deopt_reason_(kNoDeoptReason),
28 deopt_id_(kNoDeoptimizationId), 28 deopt_id_(kNoDeoptimizationId),
29 line_info_(line_info), 29 line_info_(line_info),
30 instruction_start_(instruction_start) { 30 instruction_start_(instruction_start) {}
31 // TODO(alph): Extra check to help catch crbug.com/665398
32 // Remove before 5.8 branch
33 #if V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION == 7
34 CHECK(name);
35 #endif
36 }
37 31
38 ProfileNode::ProfileNode(ProfileTree* tree, CodeEntry* entry, 32 ProfileNode::ProfileNode(ProfileTree* tree, CodeEntry* entry,
39 ProfileNode* parent) 33 ProfileNode* parent)
40 : tree_(tree), 34 : tree_(tree),
41 entry_(entry), 35 entry_(entry),
42 self_ticks_(0), 36 self_ticks_(0),
43 children_(CodeEntriesMatch), 37 children_(CodeEntriesMatch),
44 parent_(parent), 38 parent_(parent),
45 id_(tree->next_node_id()), 39 id_(tree->next_node_id()),
46 line_ticks_(LineTickMatch) { 40 line_ticks_(LineTickMatch) {
47 tree_->EnqueueNode(this); 41 tree_->EnqueueNode(this);
48 } 42 }
49 43
50 inline unsigned ProfileNode::function_id() const { 44 inline unsigned ProfileNode::function_id() const {
51 return tree_->GetFunctionId(this); 45 return tree_->GetFunctionId(this);
52 } 46 }
53 47
54 inline Isolate* ProfileNode::isolate() const { return tree_->isolate(); } 48 inline Isolate* ProfileNode::isolate() const { return tree_->isolate(); }
55 49
56 } // namespace internal 50 } // namespace internal
57 } // namespace v8 51 } // namespace v8
58 52
59 #endif // V8_PROFILER_PROFILE_GENERATOR_INL_H_ 53 #endif // V8_PROFILER_PROFILE_GENERATOR_INL_H_
OLDNEW
« no previous file with comments | « src/profiler/profile-generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698