[Downloads] Address offline pages notification

[Downloads] Address offline pages notification

Clicking on the Offline Page notification currently doesn't
do anything because there's no SharedPreference for it in
DownloadNotificationService.

This was likely broken by https://codereview.chromium.org/2544633003;
leftover code suggests that the case I'm adding to the
conditional should be alright.

BUG=675304
Committed: https://crrev.com/42470b714cddfd0d017a0443ff8e29fdb0c26784
Cr-Commit-Position: refs/heads/master@{#439617}

[gone, 2016-12-19 21:55:56]

dfalcantara@chromium.org changed reviewers:
+ twellington@chromium.org

[Theresa, 2016-12-19 21:57:32]

lgtm

[gone, 2016-12-19 22:18:29]

Description was changed from

==========
[Downloads] Address offline pages notification

Clicking on the Offline Page notification currently doesn't
do anything because there's no SharedPreference for it in
DownloadNotificationService.  Add it to the fallback case
until a better solution comes along.

BUG=675304
==========

to

==========
[Downloads] Address offline pages notification

Clicking on the Offline Page notification currently doesn't
do anything because there's no SharedPreference for it in
DownloadNotificationService.

This was likely broken by https://codereview.chromium.org/2544633003;
leftover code suggests that the case I'm adding to the
conditional should be alright.

BUG=675304
==========

[gone, 2016-12-19 22:28:46]

Theresa: Realized I wasn't properly accounting for the native library here; I
had to Frankenstein the logic from the callsite to account for Offline Pages.  I
also added a safety check to the case where this happens for regular downloads,
but I don't think it's triggerable.  Better safe than asynchronously sorry.

[gone, 2016-12-19 22:55:02]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 22:55:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2016-12-19 23:10:48]

still lgtm

[gone, 2016-12-19 23:11:20]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2016-12-19 23:11:21]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-12-19 23:11:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 23:45:08]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482189081849700,
"parent_rev": "7e80ec04b49fd250746e605bb48740edc41c5f50", "commit_rev":
"b57e25fe4827658b99bee603be420ea80808d4d1"}

[commit-bot: I haz the power, 2016-12-19 23:45:41]

Description was changed from

==========
[Downloads] Address offline pages notification

Clicking on the Offline Page notification currently doesn't
do anything because there's no SharedPreference for it in
DownloadNotificationService.

This was likely broken by https://codereview.chromium.org/2544633003;
leftover code suggests that the case I'm adding to the
conditional should be alright.

BUG=675304
==========

to

==========
[Downloads] Address offline pages notification

Clicking on the Offline Page notification currently doesn't
do anything because there's no SharedPreference for it in
DownloadNotificationService.

This was likely broken by https://codereview.chromium.org/2544633003;
leftover code suggests that the case I'm adding to the
conditional should be alright.

BUG=675304

Review-Url: https://codereview.chromium.org/2588933002
==========

[commit-bot: I haz the power, 2016-12-19 23:45:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-19 23:49:33]

Description was changed from

==========
[Downloads] Address offline pages notification

Clicking on the Offline Page notification currently doesn't
do anything because there's no SharedPreference for it in
DownloadNotificationService.

This was likely broken by https://codereview.chromium.org/2544633003;
leftover code suggests that the case I'm adding to the
conditional should be alright.

BUG=675304

Review-Url: https://codereview.chromium.org/2588933002
==========

to

==========
[Downloads] Address offline pages notification

Clicking on the Offline Page notification currently doesn't
do anything because there's no SharedPreference for it in
DownloadNotificationService.

This was likely broken by https://codereview.chromium.org/2544633003;
leftover code suggests that the case I'm adding to the
conditional should be alright.

BUG=675304

Committed: https://crrev.com/42470b714cddfd0d017a0443ff8e29fdb0c26784
Cr-Commit-Position: refs/heads/master@{#439617}
==========

[commit-bot: I haz the power, 2016-12-19 23:49:34]

Patchset 4 (id:??) landed as
https://crrev.com/42470b714cddfd0d017a0443ff8e29fdb0c26784
Cr-Commit-Position: refs/heads/master@{#439617}