Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2544633003: Remove unnecessary extra field from download notification intent (Closed)

Created:
4 years ago by qinmin
Modified:
4 years ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary extra field from download notification intent Chrome stores those information in SharedPreferences for all downloads now. So there is no need to keep those extra fields. BUG=669702 Committed: https://crrev.com/06274d14c37bebbf2e5c4acf9b0bce24ca7f2c17 Cr-Commit-Position: refs/heads/master@{#435639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -42 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 9 chunks +9 lines, -42 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
qinmin
PTAL
4 years ago (2016-11-30 22:35:35 UTC) #2
gone
lgtm
4 years ago (2016-11-30 23:00:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544633003/1
4 years ago (2016-11-30 23:06:32 UTC) #5
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
4 years ago (2016-11-30 23:42:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544633003/1
4 years ago (2016-12-01 17:28:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 17:35:08 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-01 17:37:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06274d14c37bebbf2e5c4acf9b0bce24ca7f2c17
Cr-Commit-Position: refs/heads/master@{#435639}

Powered by Google App Engine
This is Rietveld 408576698