Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2588743003: CompilerDispatcher unittest should use is_compiled() predicate. (Closed)

Created:
4 years ago by mvstanton
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CompilerDispatcher unittest should use is_compiled() predicate. BUG=v8:5759 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2588743003 Cr-Commit-Position: refs/heads/master@{#41810} Committed: https://chromium.googlesource.com/v8/v8/+/0d4b99049797b1e2e465faf89123b34c8cb5cc40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mvstanton
Hi Jochen, this CL fixes an issue that the test fails with --ignition-staging. PTAL, thx! ...
4 years ago (2016-12-19 14:46:26 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-12-19 15:16:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588743003/1
4 years ago (2016-12-19 15:17:05 UTC) #4
commit-bot: I haz the power
4 years ago (2016-12-19 15:41:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0d4b99049797b1e2e465faf89123b34c8cb...

Powered by Google App Engine
This is Rietveld 408576698