Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1931)

Unified Diff: test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc

Issue 2588743003: CompilerDispatcher unittest should use is_compiled() predicate. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc
diff --git a/test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc b/test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc
index ea3295cdf989deb68a04ec41bb4b19f96f25c6ff..a2046a4da82f22b1134bbe90fa4b94731ea42958 100644
--- a/test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc
+++ b/test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc
@@ -104,12 +104,12 @@ TEST_F(CompilerDispatcherTest, FinishNow) {
Handle<JSFunction> f = Handle<JSFunction>::cast(RunJS(isolate(), script));
Handle<SharedFunctionInfo> shared(f->shared(), i_isolate());
- ASSERT_FALSE(shared->HasBaselineCode());
+ ASSERT_FALSE(shared->is_compiled());
ASSERT_TRUE(dispatcher.Enqueue(shared));
ASSERT_TRUE(dispatcher.FinishNow(shared));
// Finishing removes the SFI from the queue.
ASSERT_FALSE(dispatcher.IsEnqueued(shared));
- ASSERT_TRUE(shared->HasBaselineCode());
+ ASSERT_TRUE(shared->is_compiled());
}
TEST_F(CompilerDispatcherTest, IdleTask) {
@@ -131,7 +131,7 @@ TEST_F(CompilerDispatcherTest, IdleTask) {
platform.RunIdleTask(1000.0, 0.0);
ASSERT_FALSE(dispatcher.IsEnqueued(shared));
- ASSERT_TRUE(shared->HasBaselineCode());
+ ASSERT_TRUE(shared->is_compiled());
}
TEST_F(CompilerDispatcherTest, IdleTaskSmallIdleTime) {
@@ -157,7 +157,7 @@ TEST_F(CompilerDispatcherTest, IdleTaskSmallIdleTime) {
platform.RunIdleTask(2.0, 1.0);
ASSERT_TRUE(dispatcher.IsEnqueued(shared));
- ASSERT_FALSE(shared->HasBaselineCode());
+ ASSERT_FALSE(shared->is_compiled());
ASSERT_TRUE(platform.IdleTaskPending());
// The job should be still scheduled for the main thread, but ready for
@@ -170,7 +170,7 @@ TEST_F(CompilerDispatcherTest, IdleTaskSmallIdleTime) {
platform.RunIdleTask(1000.0, 0.0);
ASSERT_FALSE(dispatcher.IsEnqueued(shared));
- ASSERT_TRUE(shared->HasBaselineCode());
+ ASSERT_TRUE(shared->is_compiled());
ASSERT_FALSE(platform.IdleTaskPending());
}
@@ -199,7 +199,7 @@ TEST_F(CompilerDispatcherTest, IdleTaskException) {
platform.RunIdleTask(1000.0, 0.0);
ASSERT_FALSE(dispatcher.IsEnqueued(shared));
- ASSERT_FALSE(shared->HasBaselineCode());
+ ASSERT_FALSE(shared->is_compiled());
ASSERT_FALSE(try_catch.HasCaught());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698