Remove unnecessary LifecycleObserver::clearContext

Remove unnecessary LifecycleObserver::clearContext

LifecycleObserver::clearContext is automatically called immediately after
contextDestroyed() gets called. The caller side doesn't need to call clearContext
explicitly.

BUG=610176
Committed: https://crrev.com/476bd13c7171fffc2c991495970dcaecfa8ddf69
Cr-Commit-Position: refs/heads/master@{#439431}

[haraken, 2016-12-19 06:10:58]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2016-12-19 06:10:59]

PTAL

[haraken, 2016-12-19 06:13:13]

https://codereview.chromium.org/2588663002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/vibration/VibrationController.cpp (left):

https://codereview.chromium.org/2588663002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/vibration/VibrationController.cpp:186:
PageVisibilityObserver::clearContext();

Some objects inherit from both ContextLifecycleObserver and
PageVisibilityObserver. The objects override "contextDestroyed", which is called
when the context is detached and the page is detached. This is really
confusing...

We should introduce contextDestroyed, pageDestroyed, workerThreadDestroyed etc
per lifecycle observer.

[sof, 2016-12-19 06:29:09]

lgtm

Older code based on earlier lifecycle observer&notifiers, good thing to remove
so that new modules/ code won't accidentally pattern itself on it.

[haraken, 2016-12-19 06:44:48]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-19 06:44:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 08:09:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482129888161760, "parent_rev":
"0a365c936bb721daa6f65c754bed0294253be0a9", "commit_rev":
"7a8d7a5cf045560e33c604830bd2b8a89bc44edd"}

[commit-bot: I haz the power, 2016-12-19 08:10:24]

Description was changed from

==========
Remove unnecessary LifecycleObserver::clearContext

LifecycleObserver::clearContext is automatically called immediately after
contextDestroyed() gets called. The caller side doesn't need to call
clearContext
explicitly.

BUG=610176
==========

to

==========
Remove unnecessary LifecycleObserver::clearContext

LifecycleObserver::clearContext is automatically called immediately after
contextDestroyed() gets called. The caller side doesn't need to call
clearContext
explicitly.

BUG=610176

Review-Url: https://codereview.chromium.org/2588663002
==========

[commit-bot: I haz the power, 2016-12-19 08:10:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-19 08:12:38]

Description was changed from

==========
Remove unnecessary LifecycleObserver::clearContext

LifecycleObserver::clearContext is automatically called immediately after
contextDestroyed() gets called. The caller side doesn't need to call
clearContext
explicitly.

BUG=610176

Review-Url: https://codereview.chromium.org/2588663002
==========

to

==========
Remove unnecessary LifecycleObserver::clearContext

LifecycleObserver::clearContext is automatically called immediately after
contextDestroyed() gets called. The caller side doesn't need to call
clearContext
explicitly.

BUG=610176

Committed: https://crrev.com/476bd13c7171fffc2c991495970dcaecfa8ddf69
Cr-Commit-Position: refs/heads/master@{#439431}
==========

[commit-bot: I haz the power, 2016-12-19 08:12:39]

Patchset 1 (id:??) landed as
https://crrev.com/476bd13c7171fffc2c991495970dcaecfa8ddf69
Cr-Commit-Position: refs/heads/master@{#439431}