Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: third_party/WebKit/Source/modules/vibration/VibrationController.cpp

Issue 2588663002: Remove unnecessary LifecycleObserver::clearContext (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/geolocation/Geolocation.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/vibration/VibrationController.cpp
diff --git a/third_party/WebKit/Source/modules/vibration/VibrationController.cpp b/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
index 87c9eeff61fe11912f3a7231c1a82124d30a37f7..35e4ad17b0bfd721ded3ecaf0e60fdffd8c0df01 100644
--- a/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
+++ b/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
@@ -177,13 +177,6 @@ void VibrationController::contextDestroyed() {
// If the document context was destroyed, never call the mojo service again.
m_service.reset();
-
- // The context is not automatically cleared, so do it manually.
- ContextLifecycleObserver::clearContext();
-
- // Page outlives ExecutionContext so stop observing it to avoid having
- // |pageVisibilityChanged| or |contextDestroyed| called again.
- PageVisibilityObserver::clearContext();
haraken 2016/12/19 06:13:13 Some objects inherit from both ContextLifecycleObs
}
void VibrationController::pageVisibilityChanged() {
« no previous file with comments | « third_party/WebKit/Source/modules/geolocation/Geolocation.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698