Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2588423003: Revert of Ship String.prototype.pad{Start,End} (Closed)

Created:
4 years ago by adamk
Modified:
4 years ago
Reviewers:
caitp
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Ship String.prototype.pad{Start,End} (patchset #2 id:20001 of https://codereview.chromium.org/2591853002/ ) Reason for revert: Fails on gcstress bot (mjsunit/regress/regress-trap-allocation-memento.js) Original issue's description: > Ship String.prototype.pad{Start,End} > > BUG=v8:4954 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2591853002 > Cr-Commit-Position: refs/heads/master@{#41873} > Committed: https://chromium.googlesource.com/v8/v8/+/07277202cf136e70c147e2f000e48964332bb01c TBR=caitp@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4954 Review-Url: https://codereview.chromium.org/2588423003 Cr-Commit-Position: refs/heads/master@{#41874} Committed: https://chromium.googlesource.com/v8/v8/+/6543cddc43d59ee2bdf4e6446228f7d765ef5256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/flag-definitions.h View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
adamk
Created Revert of Ship String.prototype.pad{Start,End}
4 years ago (2016-12-20 21:34:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588423003/1
4 years ago (2016-12-20 21:34:53 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-20 21:35:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6543cddc43d59ee2bdf4e6446228f7d765e...

Powered by Google App Engine
This is Rietveld 408576698