Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2588323002: Revert "Remove Finch support for PasswordBranding" (Closed)

Created:
4 years ago by vabr (Chromium)
Modified:
4 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, blundell+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, droger+watchlist_chromium.org, pkl (ping after 24h if needed), rouslan+autofill_chromium.org, tfarina, sebsg+autofillwatch_chromium.org, mac-reviews_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, sdefresne+watchlist_chromium.org, agrieve+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Remove Finch support for PasswordBranding" This reverts commit 063b99026eca67b274692d0879bfdbcd0c9b5008. Original comment: Remove Finch support for PasswordBranding PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY. This CL removes the code to obtain the Finch group for the experiment, related tests, and also the functionality only executed for the unused FULL variant of the experiment (mainly the SmartLock warm welcome). BUG=486739 Committed: https://crrev.com/063b99026eca67b274692d0879bfdbcd0c9b5008 Cr-Commit-Position: refs/heads/master@{#439740} TBR=mathp@chromium.org,vasilii@chromium.org,stanisc@chromium.org,stevenjb@chromium.org,dfalcantara@chromium.org, NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Committed: https://crrev.com/772284db098f95fa9161a662f10f91280e2c86f1 Cr-Commit-Position: refs/heads/master@{#439745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+693 lines, -100 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/PasswordUIView.java View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/chromium_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 2 chunks +15 lines, -5 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/android/password_ui_view_android.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.h View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc View 1 chunk +35 lines, -8 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/password_manager/update_password_infobar_delegate_android.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 3 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/pending_password_view_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm View 4 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model.cc View 6 chunks +40 lines, -6 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc View 9 chunks +126 lines, -33 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils_desktop.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc View 4 chunks +25 lines, -4 lines 0 comments Download
M chrome/browser/ui/passwords/passwords_model_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/passwords_model_delegate_mock.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_bubble_experiment.h View 2 chunks +32 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_bubble_experiment.cc View 2 chunks +41 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_bubble_experiment_unittest.cc View 5 chunks +222 lines, -24 lines 0 comments Download
M components/password_manager/core/common/password_manager_pref_names.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/password_manager/core/common/password_manager_pref_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/passwords/password_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
vabr (Chromium)
4 years ago (2016-12-20 08:08:46 UTC) #1
vabr (Chromium)
This broke iOS build http://build.chromium.org/p/chromium.mac/builders/ios-device/builds/34820
4 years ago (2016-12-20 08:09:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588323002/1
4 years ago (2016-12-20 08:09:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 08:10:56 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-20 08:12:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/772284db098f95fa9161a662f10f91280e2c86f1
Cr-Commit-Position: refs/heads/master@{#439745}

Powered by Google App Engine
This is Rietveld 408576698