Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6773)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc

Issue 2588323002: Revert "Remove Finch support for PasswordBranding" (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc
index 0c50d6733716c43292b578fb998026317457fc34..b0b6ad526a51d07cc990bbc2b65f51ca823201cb 100644
--- a/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc
@@ -31,6 +31,10 @@ const char kPasswordManagerSettingMigrationFieldTrialName[] =
const char kEnabledPasswordManagerSettingsMigrationGroupName[] = "Enable";
const char kDisablePasswordManagerSettingsMigrationGroupName[] = "Disable";
+const char kBrandingExperimentName[] = "PasswordBranding";
+const char kSmartLockBrandingGroupName[] = "SmartLockBranding";
+const char kSmartLockNoBrandingGroupName[] = "NoSmartLockBranding";
+
} // namespace
class ManagePasswordsViewUtilDesktopTest : public testing::Test {
@@ -50,6 +54,11 @@ class ManagePasswordsViewUtilDesktopTest : public testing::Test {
kPasswordManagerSettingMigrationFieldTrialName, name);
}
+ void EnforceSmartLockBrandingExperiment(const char* name) {
+ smart_lock_branding_ =
+ base::FieldTrialList::CreateFieldTrial(kBrandingExperimentName, name);
+ }
+
browser_sync::ProfileSyncService* GetSyncServiceForSmartLockUser() {
browser_sync::ProfileSyncServiceMock* sync_service =
static_cast<browser_sync::ProfileSyncServiceMock*>(
@@ -82,20 +91,30 @@ class ManagePasswordsViewUtilDesktopTest : public testing::Test {
TEST_F(ManagePasswordsViewUtilDesktopTest, GetPasswordManagerSettingsStringId) {
const struct {
const char* description;
+ const char* smart_lock_branding_experiment_group;
const char* settings_migration_experiment_group;
UserType user_type;
int expected_setting_description_id;
} kTestData[] = {
- {"Smart Lock User, migration active",
+ {"Smart Lock User, branding, migration active",
+ kSmartLockBrandingGroupName,
kEnabledPasswordManagerSettingsMigrationGroupName, SMART_LOCK_USER,
IDS_OPTIONS_PASSWORD_MANAGER_SMART_LOCK_ENABLE},
- {"Smart Lock User, no migration",
+ {"Smart Lock User, no branding, migration active",
+ kSmartLockNoBrandingGroupName,
+ kEnabledPasswordManagerSettingsMigrationGroupName, SMART_LOCK_USER,
+ IDS_OPTIONS_PASSWORD_MANAGER_SMART_LOCK_ENABLE},
+ {"Smart Lock User, no branding, no migration",
+ kSmartLockNoBrandingGroupName,
kDisablePasswordManagerSettingsMigrationGroupName, SMART_LOCK_USER,
IDS_OPTIONS_PASSWORD_MANAGER_ENABLE},
- {"Non Smart Lock User, no migration",
+ {"Smart Lock User, branding, no migration", kSmartLockBrandingGroupName,
+ kDisablePasswordManagerSettingsMigrationGroupName, SMART_LOCK_USER,
+ IDS_OPTIONS_PASSWORD_MANAGER_SMART_LOCK_ENABLE},
+ {"Non Smart Lock User, no migration", kSmartLockNoBrandingGroupName,
kDisablePasswordManagerSettingsMigrationGroupName, NON_SMART_LOCK_USER,
IDS_OPTIONS_PASSWORD_MANAGER_ENABLE},
- {"Non Smart Lock User, migration",
+ {"Non Smart Lock User, migration", kSmartLockNoBrandingGroupName,
kEnabledPasswordManagerSettingsMigrationGroupName, NON_SMART_LOCK_USER,
IDS_OPTIONS_PASSWORD_MANAGER_ENABLE},
};
@@ -109,6 +128,8 @@ TEST_F(ManagePasswordsViewUtilDesktopTest, GetPasswordManagerSettingsStringId) {
sync_service = GetSyncServiceForSmartLockUser();
else
sync_service = GetSyncServiceForNonSmartLockUser();
+ EnforceSmartLockBrandingExperiment(
+ test_case.smart_lock_branding_experiment_group);
EnforcePasswordManagerSettingMigrationExperiment(
test_case.settings_migration_experiment_group);
EXPECT_EQ(

Powered by Google App Engine
This is Rietveld 408576698