Change GLGetProcAddress typedef to function returning function pointer

Change GLGetProcAddress typedef to function returning function pointer

This function is actually defined to return function pointers, not
void*. It's undefined behavior to call this from a variable of the wrong
type. It's also undefined behavior to cast between a function pointer
and a void*, so we should try to avoid that.

BUG=675104
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7fd0040966be7c3ba0fc0dda7a6b39e91a845906
Cr-Commit-Position: refs/heads/master@{#441505}

[jbauman, 2016-12-20 22:57:35]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 22:58:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 23:14:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 23:14:21]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[jbauman, 2016-12-20 23:30:47]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 23:32:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 23:49:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 23:49:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbauman, 2016-12-21 00:15:43]

Description was changed from

==========
Change GLGetProcAddress typedef to function returning function pointer

This function is actually defined to return function pointers, not
void*. It's undefined behavior to call this from a variable of the wrong
type.

BUG=675104
==========

to

==========
Change GLGetProcAddress typedef to function returning function pointer

This function is actually defined to return function pointers, not
void*. It's undefined behavior to call this from a variable of the wrong
type.

BUG=675104
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2016-12-21 00:15:49]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 00:16:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-12-21 00:57:42]

Description was changed from

==========
Change GLGetProcAddress typedef to function returning function pointer

This function is actually defined to return function pointers, not
void*. It's undefined behavior to call this from a variable of the wrong
type.

BUG=675104
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Change GLGetProcAddress typedef to function returning function pointer

This function is actually defined to return function pointers, not
void*. It's undefined behavior to call this from a variable of the wrong
type. It's also undefined behavior to cast between a function pointer
and a void*, so we should try to avoid that.

BUG=675104
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-12-21 01:12:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 01:12:37]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[jbauman, 2016-12-21 01:17:48]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 01:18:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-12-21 02:21:18]

jbauman@chromium.org changed reviewers:
+ kbr@chromium.org

[commit-bot: I haz the power, 2016-12-21 06:39:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 06:39:00]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Ken Russell (switch to Gerrit), 2016-12-21 16:45:17]

https://codereview.chromium.org/2588263005/diff/60001/ui/gl/gl_implementation.h
File ui/gl/gl_implementation.h (right):

https://codereview.chromium.org/2588263005/diff/60001/ui/gl/gl_implementation...
ui/gl/gl_implementation.h:38: using GLFunctionPointerType = void (*)();
Is it OK that this "using" statement doesn't include the calling convention
WINAPI on Windows platforms? Given that everything compiles and passes tests I
assume it is, but the GL headers all use that specifier on the function pointers
they define.

[jbauman, 2016-12-21 21:38:46]

On 2016/12/21 16:45:17, Ken Russell wrote:
>
https://codereview.chromium.org/2588263005/diff/60001/ui/gl/gl_implementation.h
> File ui/gl/gl_implementation.h (right):
> 
>
https://codereview.chromium.org/2588263005/diff/60001/ui/gl/gl_implementation...
> ui/gl/gl_implementation.h:38: using GLFunctionPointerType = void (*)();
> Is it OK that this "using" statement doesn't include the calling convention
> WINAPI on Windows platforms? Given that everything compiles and passes tests I
> assume it is, but the GL headers all use that specifier on the function
pointers
> they define.

Yeah, I think this is allowed as long we don't try to call into the function
pointer with the incorrect calling convention (or number of arguments, or
whatever). We always cast these to the correct type before calling them.

[Ken Russell (switch to Gerrit), 2016-12-21 22:29:56]

On 2016/12/21 21:38:46, jbauman wrote:
> On 2016/12/21 16:45:17, Ken Russell wrote:
> >
>
https://codereview.chromium.org/2588263005/diff/60001/ui/gl/gl_implementation.h
> > File ui/gl/gl_implementation.h (right):
> > 
> >
>
https://codereview.chromium.org/2588263005/diff/60001/ui/gl/gl_implementation...
> > ui/gl/gl_implementation.h:38: using GLFunctionPointerType = void (*)();
> > Is it OK that this "using" statement doesn't include the calling convention
> > WINAPI on Windows platforms? Given that everything compiles and passes tests
I
> > assume it is, but the GL headers all use that specifier on the function
> pointers
> > they define.
> 
> Yeah, I think this is allowed as long we don't try to call into the function
> pointer with the incorrect calling convention (or number of arguments, or
> whatever). We always cast these to the correct type before calling them.

OK. LGTM

[jbauman, 2016-12-21 22:41:20]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2016-12-21 22:41:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 22:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 22:52:36]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbauman, 2016-12-21 23:33:19]

jbauman@chromium.org changed reviewers:
+ halliwell@chromium.org

[jbauman, 2016-12-21 23:33:19]

halliwell@: ui/ozone/platform/cast OWNERS review.

[halliwell, 2016-12-27 14:35:38]

On 2016/12/21 23:33:19, jbauman wrote:
> halliwell@: ui/ozone/platform/cast OWNERS review.

lgtm

[jbauman, 2017-01-04 22:26:51]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2017-01-04 22:27:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 23:27:14]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483568811861290,
"parent_rev": "94a1623e316c075e771a392a6989bc77b4158a0d", "commit_rev":
"c81abfa0790ac0c69f8ea790adf65c5afa4c16ff"}

[commit-bot: I haz the power, 2017-01-04 23:27:46]

Description was changed from

==========
Change GLGetProcAddress typedef to function returning function pointer

This function is actually defined to return function pointers, not
void*. It's undefined behavior to call this from a variable of the wrong
type. It's also undefined behavior to cast between a function pointer
and a void*, so we should try to avoid that.

BUG=675104
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Change GLGetProcAddress typedef to function returning function pointer

This function is actually defined to return function pointers, not
void*. It's undefined behavior to call this from a variable of the wrong
type. It's also undefined behavior to cast between a function pointer
and a void*, so we should try to avoid that.

BUG=675104
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2588263005
==========

[commit-bot: I haz the power, 2017-01-04 23:27:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2017-01-04 23:29:49]

Description was changed from

==========
Change GLGetProcAddress typedef to function returning function pointer

This function is actually defined to return function pointers, not
void*. It's undefined behavior to call this from a variable of the wrong
type. It's also undefined behavior to cast between a function pointer
and a void*, so we should try to avoid that.

BUG=675104
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2588263005
==========

to

==========
Change GLGetProcAddress typedef to function returning function pointer

This function is actually defined to return function pointers, not
void*. It's undefined behavior to call this from a variable of the wrong
type. It's also undefined behavior to cast between a function pointer
and a void*, so we should try to avoid that.

BUG=675104
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7fd0040966be7c3ba0fc0dda7a6b39e91a845906
Cr-Commit-Position: refs/heads/master@{#441505}
==========

[commit-bot: I haz the power, 2017-01-04 23:29:50]

Patchset 4 (id:??) landed as
https://crrev.com/7fd0040966be7c3ba0fc0dda7a6b39e91a845906
Cr-Commit-Position: refs/heads/master@{#441505}