Reland: Remove Finch support for PasswordBranding

Reland: Remove Finch support for PasswordBranding

PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY.

This CL removes the code to obtain the Finch group for the experiment, related
tests, and also the functionality only executed for the unused FULL variant of
the experiment (mainly the SmartLock warm welcome).

BUG=486739
Original Review-Url: https://codereview.chromium.org/2579823003
Original Cr-Commit-Position: refs/heads/master@{#439740}

Reverted because of breaking iOS build.

Patch set 1 here is the reverted one, subsequent patches are fixing the breakage.

TBR=mathp@chromium.org,vasilii@chromium.org,stanisc@chromium.org,stevenjb@chromium.org,dfalcantara@chromium.org,

Committed: https://crrev.com/9b0b15bee907f8dcaebae29464463e189b814522
Cr-Commit-Position: refs/heads/master@{#439799}

[vabr (Chromium), 2016-12-20 08:34:06]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 08:34:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 08:42:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 08:42:07]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[vabr (Chromium), 2016-12-20 08:46:13]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 08:46:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-12-20 08:54:19]

Description was changed from

==========
Reland: Remove Finch support for PasswordBranding

PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY.

This CL removes the code to obtain the Finch group for the experiment, related
tests, and also the functionality only executed for the unused FULL variant of
the experiment (mainly the SmartLock warm welcome).

BUG=486739

Original Review-Url: https://codereview.chromium.org/2579823003
Original Cr-Commit-Position: refs/heads/master@{#439740}

Reverted because of breaking iOS build.

Patch set 1 here is the reverted one, subsequent patches are fixing the
breakage.
==========

to

==========
Reland: Remove Finch support for PasswordBranding

PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY.

This CL removes the code to obtain the Finch group for the experiment, related
tests, and also the functionality only executed for the unused FULL variant of
the experiment (mainly the SmartLock warm welcome).

BUG=486739

Original Review-Url: https://codereview.chromium.org/2579823003
Original Cr-Commit-Position: refs/heads/master@{#439740}

Reverted because of breaking iOS build.

Patch set 1 here is the reverted one, subsequent patches are fixing the
breakage.


TBR=mathp@chromium.org,vasilii@chromium.org,stanisc@chromium.org,stevenjb@chr...,
==========

[vabr (Chromium), 2016-12-20 08:54:19]

vabr@chromium.org changed reviewers:
+ dfalcantara@chromium.org, lpromero@chromium.org, marq@chromium.org,
mathp@chromium.org, stanisc@chromium.org, stevenjb@chromium.org,
vasilii@chromium.org

[vabr (Chromium), 2016-12-20 08:57:27]

Hi all!

Relanding this CL after fixing the iOS breakage it caused. (I'm very lucky that
the Chrome on iOS team upstreamed just last night (Woohoo!), so I could actually
see the breakage upstream.)

lpromero@ -- please review ios/chrome/browser/ui/settings/*

marq@ -- please review ios/chrome/app/strings/ios_strings.grd

Everyone else is TBR-ed, because changes to the other files are the same as in
the already approved https://codereview.chromium.org/2579823003.

Thanks,
Vaclav

[vabr (Chromium), 2016-12-20 08:59:06]

An explanation for lpromero@.

https://codereview.chromium.org/2588263003/diff/40001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
(left):

https://codereview.chromium.org/2588263003/diff/40001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm:189:
if (password_bubble_experiment::IsSmartLockBrandingEnabled(syncService)) {
This translates to an old Finch experiment group, which has not been and will
never be used (the Finch experiment has been finally launched in a different
version).

[marq (ping after 24h), 2016-12-20 09:11:56]

ior/chrome/app/ LGTM

[commit-bot: I haz the power, 2016-12-20 09:42:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 09:42:59]

Dry run: This issue passed the CQ dry run.

[vasilii, 2016-12-20 10:28:31]

lgtm

[sdefresne, 2016-12-20 12:03:24]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2016-12-20 12:03:25]

ios/chrome lgtm

[vabr (Chromium), 2016-12-20 13:32:06]

On 2016/12/20 12:03:25, sdefresne wrote:
> ios/chrome lgtm

Thanks, sdefresne@!
I cannot stop smiling seeing all the downstream files upstream now :D. You
people rock.

Cheers,
Vaclav

[vabr (Chromium), 2016-12-20 13:32:14]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-12-20 13:32:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 13:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 13:38:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vabr (Chromium), 2016-12-20 13:44:19]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-12-20 13:44:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
vasilii@chromium.org, marq@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2588263003/#ps60001
(title: "Rebased only")

[commit-bot: I haz the power, 2016-12-20 13:44:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 14:40:03]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482241459970810,
"parent_rev": "ee2392000a31e2180dda008968474a0b41ee8250", "commit_rev":
"99b5987d10d49eb02b8f7d242c25cf7a5b2cf2e4"}

[commit-bot: I haz the power, 2016-12-20 14:40:39]

Description was changed from

==========
Reland: Remove Finch support for PasswordBranding

PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY.

This CL removes the code to obtain the Finch group for the experiment, related
tests, and also the functionality only executed for the unused FULL variant of
the experiment (mainly the SmartLock warm welcome).

BUG=486739

Original Review-Url: https://codereview.chromium.org/2579823003
Original Cr-Commit-Position: refs/heads/master@{#439740}

Reverted because of breaking iOS build.

Patch set 1 here is the reverted one, subsequent patches are fixing the
breakage.


TBR=mathp@chromium.org,vasilii@chromium.org,stanisc@chromium.org,stevenjb@chr...,
==========

to

==========
Reland: Remove Finch support for PasswordBranding

PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY.

This CL removes the code to obtain the Finch group for the experiment, related
tests, and also the functionality only executed for the unused FULL variant of
the experiment (mainly the SmartLock warm welcome).

BUG=486739

Original Review-Url: https://codereview.chromium.org/2579823003
Original Cr-Commit-Position: refs/heads/master@{#439740}

Reverted because of breaking iOS build.

Patch set 1 here is the reverted one, subsequent patches are fixing the
breakage.


TBR=mathp@chromium.org,vasilii@chromium.org,stanisc@chromium.org,stevenjb@chr...,

Review-Url: https://codereview.chromium.org/2588263003
==========

[commit-bot: I haz the power, 2016-12-20 14:40:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-20 14:42:47]

Description was changed from

==========
Reland: Remove Finch support for PasswordBranding

PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY.

This CL removes the code to obtain the Finch group for the experiment, related
tests, and also the functionality only executed for the unused FULL variant of
the experiment (mainly the SmartLock warm welcome).

BUG=486739

Original Review-Url: https://codereview.chromium.org/2579823003
Original Cr-Commit-Position: refs/heads/master@{#439740}

Reverted because of breaking iOS build.

Patch set 1 here is the reverted one, subsequent patches are fixing the
breakage.


TBR=mathp@chromium.org,vasilii@chromium.org,stanisc@chromium.org,stevenjb@chr...,

Review-Url: https://codereview.chromium.org/2588263003
==========

to

==========
Reland: Remove Finch support for PasswordBranding

PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY.

This CL removes the code to obtain the Finch group for the experiment, related
tests, and also the functionality only executed for the unused FULL variant of
the experiment (mainly the SmartLock warm welcome).

BUG=486739

Original Review-Url: https://codereview.chromium.org/2579823003
Original Cr-Commit-Position: refs/heads/master@{#439740}

Reverted because of breaking iOS build.

Patch set 1 here is the reverted one, subsequent patches are fixing the
breakage.

TBR=mathp@chromium.org,vasilii@chromium.org,stanisc@chromium.org,stevenjb@chr...,

Committed: https://crrev.com/9b0b15bee907f8dcaebae29464463e189b814522
Cr-Commit-Position: refs/heads/master@{#439799}
==========

[commit-bot: I haz the power, 2016-12-20 14:42:49]

Patchset 4 (id:??) landed as
https://crrev.com/9b0b15bee907f8dcaebae29464463e189b814522
Cr-Commit-Position: refs/heads/master@{#439799}