Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2588163002:
S390: Change LoadP to LoadB for TestIfSmi (Closed)
DescriptionS390: Change LoadP to LoadB for TestIfSmi
R=jyan@ca.ibm.com, joransiu@ca.ibm.com,
BUG=
Review-Url: https://codereview.chromium.org/2588163002
Cr-Commit-Position: refs/heads/master@{#41829}
Committed: https://chromium.googlesource.com/v8/v8/+/787f1596b6f10f53fcce46335238039979558990
Patch Set 1 #
Messages
Total messages: 21 (16 generated)
Description was changed from ========== S390: Change LoadP to LoadB for TestIfSmi BUG= ========== to ========== S390: Change LoadP to LoadB for TestIfSmi BUG= ==========
Description was changed from ========== S390: Change LoadP to LoadB for TestIfSmi BUG= ========== to ========== S390: Change LoadP to LoadB for TestIfSmi BUG= ==========
sampsong@ca.ibm.com changed reviewers: + joransiu@ca.ibm.com, jyan@ca.ibm.com
sampsong@ca.ibm.com changed reviewers: + joransiu@ca.ibm.com, jyan@ca.ibm.com
Description was changed from ========== S390: Change LoadP to LoadB for TestIfSmi BUG= ========== to ========== S390: Change LoadP to LoadB for TestIfSmi R=jyan@ca.ibm.com, joransiu@ca.ibm.com, BUG= ==========
Please take a look.
The CQ bit was checked by sampsong@ca.ibm.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
On 2016/12/19 21:57:02, Sampson wrote: > Please take a look. lgtm
lgtm
The CQ bit was checked by sampsong@ca.ibm.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sampsong@ca.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482186256907960, "parent_rev":
"0625a686b5971b36b0116ec5c8cebf4428689cb4", "commit_rev":
"787f1596b6f10f53fcce46335238039979558990"}
Message was sent while issue was closed.
Description was changed from ========== S390: Change LoadP to LoadB for TestIfSmi R=jyan@ca.ibm.com, joransiu@ca.ibm.com, BUG= ========== to ========== S390: Change LoadP to LoadB for TestIfSmi R=jyan@ca.ibm.com, joransiu@ca.ibm.com, BUG= Review-Url: https://codereview.chromium.org/2588163002 Cr-Commit-Position: refs/heads/master@{#41829} Committed: https://chromium.googlesource.com/v8/v8/+/787f1596b6f10f53fcce463352380399795... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/787f1596b6f10f53fcce463352380399795... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
