Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/s390/macro-assembler-s390.h

Issue 2588163002: S390: Change LoadP to LoadB for TestIfSmi (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_S390_MACRO_ASSEMBLER_S390_H_ 5 #ifndef V8_S390_MACRO_ASSEMBLER_S390_H_
6 #define V8_S390_MACRO_ASSEMBLER_S390_H_ 6 #define V8_S390_MACRO_ASSEMBLER_S390_H_
7 7
8 #include "src/assembler.h" 8 #include "src/assembler.h"
9 #include "src/bailout-reason.h" 9 #include "src/bailout-reason.h"
10 #include "src/frames.h" 10 #include "src/frames.h"
(...skipping 1521 matching lines...) Expand 10 before | Expand all | Expand 10 after
1532 void UntagAndJumpIfSmi(Register dst, Register src, Label* smi_case); 1532 void UntagAndJumpIfSmi(Register dst, Register src, Label* smi_case);
1533 1533
1534 inline void TestIfSmi(Register value) { tmll(value, Operand(1)); } 1534 inline void TestIfSmi(Register value) { tmll(value, Operand(1)); }
1535 1535
1536 inline void TestIfSmi(MemOperand value) { 1536 inline void TestIfSmi(MemOperand value) {
1537 if (is_uint12(value.offset())) { 1537 if (is_uint12(value.offset())) {
1538 tm(value, Operand(1)); 1538 tm(value, Operand(1));
1539 } else if (is_int20(value.offset())) { 1539 } else if (is_int20(value.offset())) {
1540 tmy(value, Operand(1)); 1540 tmy(value, Operand(1));
1541 } else { 1541 } else {
1542 LoadP(r0, value); 1542 LoadB(r0, value);
1543 tmll(r0, Operand(1)); 1543 tmll(r0, Operand(1));
1544 } 1544 }
1545 } 1545 }
1546 1546
1547 inline void TestIfPositiveSmi(Register value, Register scratch) { 1547 inline void TestIfPositiveSmi(Register value, Register scratch) {
1548 STATIC_ASSERT((kSmiTagMask | kSmiSignMask) == 1548 STATIC_ASSERT((kSmiTagMask | kSmiSignMask) ==
1549 (intptr_t)(1UL << (kBitsPerPointer - 1) | 1)); 1549 (intptr_t)(1UL << (kBitsPerPointer - 1) | 1));
1550 mov(scratch, Operand(kIntptrSignBit | kSmiTagMask)); 1550 mov(scratch, Operand(kIntptrSignBit | kSmiTagMask));
1551 AndP(scratch, value); 1551 AndP(scratch, value);
1552 } 1552 }
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
1810 inline MemOperand NativeContextMemOperand() { 1810 inline MemOperand NativeContextMemOperand() {
1811 return ContextMemOperand(cp, Context::NATIVE_CONTEXT_INDEX); 1811 return ContextMemOperand(cp, Context::NATIVE_CONTEXT_INDEX);
1812 } 1812 }
1813 1813
1814 #define ACCESS_MASM(masm) masm-> 1814 #define ACCESS_MASM(masm) masm->
1815 1815
1816 } // namespace internal 1816 } // namespace internal
1817 } // namespace v8 1817 } // namespace v8
1818 1818
1819 #endif // V8_S390_MACRO_ASSEMBLER_S390_H_ 1819 #endif // V8_S390_MACRO_ASSEMBLER_S390_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698