Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2587973002: Revert of [crankshaft] Fix IsClassOfTest helper method (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [crankshaft] Fix IsClassOfTest helper method (patchset #1 id:1 of https://codereview.chromium.org/2586933002/ ) Reason for revert: Breaks vtune: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20vtunejit/builds/15379 Original issue's description: > [crankshaft] Fix IsClassOfTest helper method > > Drive-by-fix: Add AstNode::Print() and improve printing of CallRuntime > Expression. > > BUG=v8:5749 > > Review-Url: https://codereview.chromium.org/2586933002 > Cr-Commit-Position: refs/heads/master@{#41792} > Committed: https://chromium.googlesource.com/v8/v8/+/d4493222b958877e51ebd67399d12a80ec848e30 TBR=bmeurer@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5749 Review-Url: https://codereview.chromium.org/2587973002 Cr-Commit-Position: refs/heads/master@{#41795} Committed: https://chromium.googlesource.com/v8/v8/+/81dd9847cfda78dfe5252f875f2932066a6021fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -36 lines) Patch
M src/ast/ast.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/ast.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ast/prettyprinter.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +6 lines, -3 lines 0 comments Download
D test/mjsunit/regress/regress-5749.js View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [crankshaft] Fix IsClassOfTest helper method
4 years ago (2016-12-19 11:22:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587973002/1
4 years ago (2016-12-19 11:22:30 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-19 11:22:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/81dd9847cfda78dfe5252f875f2932066a6...

Powered by Google App Engine
This is Rietveld 408576698