Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2586933002: [crankshaft] Fix IsClassOfTest helper method (Closed)

Created:
4 years ago by Camillo Bruni
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix IsClassOfTest helper method Drive-by-fix: Add AstNode::Print() and improve printing of CallRuntime Expression. BUG=v8:5749 Review-Url: https://codereview.chromium.org/2586933002 Cr-Commit-Position: refs/heads/master@{#41803} Committed: https://chromium.googlesource.com/v8/v8/+/99a5aa1b959368ababf54a7bd4f9a92c54c78091

Patch Set 1 #

Patch Set 2 : add missing cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M src/ast/ast.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast/ast.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ast/prettyprinter.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +3 lines, -6 lines 0 comments Download
A test/mjsunit/regress/regress-5749.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
Camillo Bruni
PTAL
4 years ago (2016-12-19 10:02:54 UTC) #4
Benedikt Meurer
lgtm
4 years ago (2016-12-19 10:42:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586933002/1
4 years ago (2016-12-19 10:43:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/d4493222b958877e51ebd67399d12a80ec848e30
4 years ago (2016-12-19 10:45:53 UTC) #12
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2587973002/ by machenbach@chromium.org. ...
4 years ago (2016-12-19 11:22:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586933002/20001
4 years ago (2016-12-19 12:47:44 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-19 12:49:26 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/99a5aa1b959368ababf54a7bd4f9a92c54c...

Powered by Google App Engine
This is Rietveld 408576698