[intl] Avoid modifying options bag from constructor

[intl] Avoid modifying options bag from constructor

Previously, the Intl.DateTimeFormat constructor and other related paths had
a bug where the options bag passed in would be modified in place. This patch
makes V8's Intl implementation follow the specification's logic to avoid
such a modification.

BUG=v8:4219
Review-Url: https://codereview.chromium.org/2587703002
Cr-Commit-Position: refs/heads/master@{#41826}
Committed: https://chromium.googlesource.com/v8/v8/+/48a36c7df71c767d2635d0b2d08ed5c93c862a86

[Dan Ehrenberg, 2016-12-18 06:04:05]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-18 06:04:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-12-18 06:04:18]

littledan@chromium.org changed reviewers:
+ yangguo@chromium.org

[commit-bot: I haz the power, 2016-12-18 06:22:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-18 06:22:23]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Dan Ehrenberg, 2016-12-18 07:00:41]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-18 07:00:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-18 07:14:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-18 07:14:22]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)

[Dan Ehrenberg, 2016-12-18 07:20:37]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-18 07:20:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-18 07:46:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-18 07:46:20]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-12-19 12:00:05]

On 2016/12/18 06:04:19, Dan Ehrenberg wrote:

lgtm.

[Dan Ehrenberg, 2016-12-19 21:06:39]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-12-19 21:06:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 21:36:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482181599224360,
"parent_rev": "6cc91d6a1336fdfcdd0e7ffea307dbd506a80a4f", "commit_rev":
"48a36c7df71c767d2635d0b2d08ed5c93c862a86"}

[commit-bot: I haz the power, 2016-12-19 21:36:22]

Description was changed from

==========
[intl] Avoid modifying options bag from constructor

Previously, the Intl.DateTimeFormat constructor and other related paths had
a bug where the options bag passed in would be modified in place. This patch
makes V8's Intl implementation follow the specification's logic to avoid
such a modification.

BUG=v8:4219
==========

to

==========
[intl] Avoid modifying options bag from constructor

Previously, the Intl.DateTimeFormat constructor and other related paths had
a bug where the options bag passed in would be modified in place. This patch
makes V8's Intl implementation follow the specification's logic to avoid
such a modification.

BUG=v8:4219

Review-Url: https://codereview.chromium.org/2587703002
Cr-Commit-Position: refs/heads/master@{#41826}
Committed:
https://chromium.googlesource.com/v8/v8/+/48a36c7df71c767d2635d0b2d08ed5c93c8...
==========

[commit-bot: I haz the power, 2016-12-19 21:36:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/48a36c7df71c767d2635d0b2d08ed5c93c8...