src/js/i18n.js - Issue 2587703002: [intl] Avoid modifying options bag from constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/i18n.js

Issue 2587703002: [intl] Avoid modifying options bag from constructor (Closed)

Patch Set: Fix test expectations Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/i18n.js

diff --git a/src/js/i18n.js b/src/js/i18n.js

index b051b090bcee57af0da4a558eb4c79fa824ba426..c41d0a2caa51186c0ad935450fdc6e1a1697520a 100644

--- a/src/js/i18n.js

+++ b/src/js/i18n.js

@@ -1518,6 +1518,8 @@ function toDateTimeOptions(options, required, defaults) {

options = TO_OBJECT(options);

}

+ options = %object_create(options);

var needsDefault = true;

if ((required === 'date' || required === 'any') &&

(!IS_UNDEFINED(options.weekday) || !IS_UNDEFINED(options.year) ||

« no previous file with comments | « src/contexts.h ('k') | test/cctest/interpreter/bytecode_expectations/CallRuntime.golden » ('j') | no next file with comments »