Media Remoting: Switch to remoting only when media is playing.

Media Remoting: Switch to remoting only when media is playing.

BUG=643964
Committed: https://crrev.com/48a9cb7e1005d106e36cd6ec139d3d2020b8f0d3
Cr-Commit-Position: refs/heads/master@{#439698}

[xjz, 2016-12-17 01:32:21]

Patchset #1 (id:1) has been deleted

[xjz, 2016-12-17 01:33:20]

The CQ bit was checked by xjz@chromium.org to run a CQ dry run

[xjz, 2016-12-17 01:34:00]

xjz@chromium.org changed reviewers:
+ miu@chromium.org, xhwang@chromium.org

[xjz, 2016-12-17 01:34:01]

PTAL. Thanks!

[commit-bot: I haz the power, 2016-12-17 01:34:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 02:45:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 02:45:56]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xhwang, 2016-12-17 05:27:58]

media base/blink lgtm

[xjz, 2016-12-17 20:59:24]

The CQ bit was checked by xjz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-17 20:59:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 21:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 21:51:47]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[miu, 2016-12-19 22:56:54]

lgtm

https://codereview.chromium.org/2587613002/diff/40001/media/remoting/remoting...
File media/remoting/remoting_renderer_controller.cc (right):

https://codereview.chromium.org/2587613002/diff/40001/media/remoting/remoting...
media/remoting/remoting_renderer_controller.cc:281: if (should_be_remoting &&
is_paused_)
Let's add a comment to explain why this is good for the user experience.

https://codereview.chromium.org/2587613002/diff/40001/media/remoting/remoting...
media/remoting/remoting_renderer_controller.cc:282: return;  // Only switches to
remoting when media is playing.
s/switches/switch/

[xjz, 2016-12-20 00:08:08]

Patchset #3 (id:60001) has been deleted

[xjz, 2016-12-20 00:12:36]

Thanks for reviewing. Addressed the comments.

https://codereview.chromium.org/2587613002/diff/40001/media/remoting/remoting...
File media/remoting/remoting_renderer_controller.cc (right):

https://codereview.chromium.org/2587613002/diff/40001/media/remoting/remoting...
media/remoting/remoting_renderer_controller.cc:281: if (should_be_remoting &&
is_paused_)
On 2016/12/19 22:56:53, miu wrote:
> Let's add a comment to explain why this is good for the user experience.

Done.

https://codereview.chromium.org/2587613002/diff/40001/media/remoting/remoting...
media/remoting/remoting_renderer_controller.cc:282: return;  // Only switches to
remoting when media is playing.
On 2016/12/19 22:56:53, miu wrote:
> s/switches/switch/

Done.

[xjz, 2016-12-20 00:12:45]

The CQ bit was checked by xjz@chromium.org

[xjz, 2016-12-20 00:12:45]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
miu@chromium.org
Link to the patchset: https://codereview.chromium.org/2587613002/#ps80001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-12-20 00:13:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 04:02:53]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482192765155510,
"parent_rev": "c15f4e860cffaa4425beb527c6ebd6a5b27ceb04", "commit_rev":
"105196328a18c1bd7ab7446fa9261eaa57e26805"}

[commit-bot: I haz the power, 2016-12-20 04:03:17]

Description was changed from

==========
Media Remoting: Switch to remoting only when media is playing.

BUG=643964
==========

to

==========
Media Remoting: Switch to remoting only when media is playing.

BUG=643964

Review-Url: https://codereview.chromium.org/2587613002
==========

[commit-bot: I haz the power, 2016-12-20 04:03:18]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-12-20 04:05:27]

Description was changed from

==========
Media Remoting: Switch to remoting only when media is playing.

BUG=643964

Review-Url: https://codereview.chromium.org/2587613002
==========

to

==========
Media Remoting: Switch to remoting only when media is playing.

BUG=643964

Committed: https://crrev.com/48a9cb7e1005d106e36cd6ec139d3d2020b8f0d3
Cr-Commit-Position: refs/heads/master@{#439698}
==========

[commit-bot: I haz the power, 2016-12-20 04:05:28]

Patchset 3 (id:??) landed as
https://crrev.com/48a9cb7e1005d106e36cd6ec139d3d2020b8f0d3
Cr-Commit-Position: refs/heads/master@{#439698}