Media Remoting: Switch to remoting only when media is playing.

media/remoting/remoting_renderer_controller_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/remoting/remoting_renderer_controller.h"
 
 #include "base/callback.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "media/base/audio_decoder_config.h"
@@ skipping 72 matching lines @@
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnEnteredFullscreen();
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnMetadataChanged(DefaultMetadata());
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnRemotePlaybackDisabled(false);
   RunUntilIdle();
+  EXPECT_FALSE(is_rendering_remotely_);
+  remoting_renderer_controller_->OnPlaying();
+  RunUntilIdle();
   EXPECT_TRUE(is_rendering_remotely_);  // All requirements now satisfied.
 
   // Leaving fullscreen should shut down remoting.
   remoting_renderer_controller_->OnExitedFullscreen();
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
 }
 
 TEST_F(RemotingRendererControllerTest, ToggleRendererOnSinkCapabilities) {
   EXPECT_FALSE(is_rendering_remotely_);
   scoped_refptr<RemotingSourceImpl> remoting_source_impl =
       CreateRemotingSourceImpl(false);
   remoting_renderer_controller_ =
       base::MakeUnique<RemotingRendererController>(remoting_source_impl);
   remoting_renderer_controller_->SetSwitchRendererCallback(base::Bind(
       &RemotingRendererControllerTest::ToggleRenderer, base::Unretained(this)));
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnMetadataChanged(DefaultMetadata());
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnRemotePlaybackDisabled(false);
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
+  remoting_renderer_controller_->OnPlaying();
+  RunUntilIdle();
+  EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnEnteredFullscreen();
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   // An available sink that does not support remote rendering should not cause
   // the controller to toggle remote rendering on.
   remoting_source_impl->OnSinkAvailable(mojom::RemotingSinkCapabilities::NONE);
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_source_impl->OnSinkGone();  // Bye-bye useless sink!
   RunUntilIdle();
@@ skipping 25 matching lines @@
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnMetadataChanged(DefaultMetadata());
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnEnteredFullscreen();
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnRemotePlaybackDisabled(false);
   RunUntilIdle();
+  EXPECT_FALSE(is_rendering_remotely_);
+  remoting_renderer_controller_->OnPlaying();
+  RunUntilIdle();
   EXPECT_TRUE(is_rendering_remotely_);  // All requirements now satisfied.
 
   // If the page disables remote playback (e.g., by setting the
   // disableRemotePlayback attribute), this should shut down remoting.
   remoting_renderer_controller_->OnRemotePlaybackDisabled(true);
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
 }
 
 TEST_F(RemotingRendererControllerTest, StartFailed) {
@@ skipping 11 matching lines @@
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnEnteredFullscreen();
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnMetadataChanged(DefaultMetadata());
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnRemotePlaybackDisabled(false);
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
+  remoting_renderer_controller_->OnPlaying();
+  RunUntilIdle();
+  EXPECT_FALSE(is_rendering_remotely_);
 }
 
 TEST_F(RemotingRendererControllerTest, EncryptedWithRemotingCdm) {
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_ = base::MakeUnique<RemotingRendererController>(
       CreateRemotingSourceImpl(false));
   remoting_renderer_controller_->SetSwitchRendererCallback(base::Bind(
       &RemotingRendererControllerTest::ToggleRenderer, base::Unretained(this)));
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnMetadataChanged(EncryptedMetadata());
   remoting_renderer_controller_->OnRemotePlaybackDisabled(false);
+  remoting_renderer_controller_->OnPlaying();
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   scoped_refptr<RemotingSourceImpl> cdm_remoting_source_impl =
       CreateRemotingSourceImpl(false);
   std::unique_ptr<RemotingCdmController> remoting_cdm_controller =
       base::MakeUnique<RemotingCdmController>(cdm_remoting_source_impl);
   cdm_remoting_source_impl->OnSinkAvailable(kAllCapabilities);
   remoting_cdm_controller->ShouldCreateRemotingCdm(base::Bind(
       &RemotingRendererControllerTest::CreateCdm, base::Unretained(this)));
   RunUntilIdle();
@@ skipping 45 matching lines @@
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnEnteredFullscreen();
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnMetadataChanged(EncryptedMetadata());
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnRemotePlaybackDisabled(false);
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
+  remoting_renderer_controller_->OnPlaying();
+  RunUntilIdle();
+  EXPECT_FALSE(is_rendering_remotely_);
 
   scoped_refptr<RemotingSourceImpl> cdm_remoting_source_impl =
       CreateRemotingSourceImpl(true);
   std::unique_ptr<RemotingCdmController> remoting_cdm_controller =
       base::MakeUnique<RemotingCdmController>(cdm_remoting_source_impl);
   cdm_remoting_source_impl->OnSinkAvailable(kAllCapabilities);
   remoting_cdm_controller->ShouldCreateRemotingCdm(base::Bind(
       &RemotingRendererControllerTest::CreateCdm, base::Unretained(this)));
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
@@ skipping 10 matching lines @@
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnEnteredFullscreen();
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnMetadataChanged(EncryptedMetadata());
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
   remoting_renderer_controller_->OnRemotePlaybackDisabled(false);
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
+  remoting_renderer_controller_->OnPlaying();
+  RunUntilIdle();
+  EXPECT_FALSE(is_rendering_remotely_);
 
   scoped_refptr<RemotingSourceImpl> cdm_remoting_source_impl =
       CreateRemotingSourceImpl(false);
   std::unique_ptr<RemotingCdmController> remoting_cdm_controller =
       base::MakeUnique<RemotingCdmController>(cdm_remoting_source_impl);
   cdm_remoting_source_impl->OnSinkAvailable(kAllCapabilities);
   remoting_cdm_controller->ShouldCreateRemotingCdm(base::Bind(
       &RemotingRendererControllerTest::CreateCdm, base::Unretained(this)));
   RunUntilIdle();
   EXPECT_FALSE(is_rendering_remotely_);
@@ skipping 14 matching lines @@
   remoting_renderer_controller_->OnSetCdm(remoting_cdm_context.get());
   RunUntilIdle();
   // Switch to using the remoting renderer, even when the remoting CDM session
   // was already terminated, to show the failure interstitial.
   EXPECT_TRUE(is_rendering_remotely_);
   EXPECT_EQ(RemotingSessionState::SESSION_PERMANENTLY_STOPPED,
             remoting_renderer_controller_->remoting_source()->state());
 }
 
 }  // namespace media