Issue 258753003: ASSERTION FAILED: !begin.isIndefinite() in WebCore::SVGSMILElement::resolveFirstInterval

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258753003: ASSERTION FAILED: !begin.isIndefinite() in WebCore::SVGSMILElement::resolveFirstInterval (Closed)

Created:
6 years, 8 months ago by reni

Modified:
6 years, 7 months ago

Reviewers:
pdr., fs

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, pdr., Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

ASSERTION FAILED: !begin.isIndefinite() in WebCore::SVGSMILElement::resolveFirstInterval According to smil animation reference, max attribute cannot be 0. This is a backport from WebKit r167761. Patch by Tamas Gergely and reviewed by Darin Adler. R=pdr@chromium.org BUG=367038 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172898

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -1 line)			Patch
A	LayoutTests/svg/animations/smil-animation-max-attribute-zero-crash.html	View	1 chunk	+11 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/animations/smil-animation-max-attribute-zero-crash-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/svg/animation/SVGSMILElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

LGTM I'd really like to see the commit sibject be more descriptive than "ASSERTION FAILED: ...

6 years, 8 months ago (2014-04-25 09:11:48 UTC) #2

reni

The CQ bit was checked by rhodovan.u-szeged@partner.samsung.com

6 years, 7 months ago (2014-04-29 13:01:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhodovan.u-szeged@partner.samsung.com/258753003/1

6 years, 7 months ago (2014-04-29 13:01:17 UTC) #4

Message was sent while issue was closed.

Change committed as 172898

Expand Messages | Collapse Messages