Source/core/svg/animation/SVGSMILElement.cpp - Issue 258753003: ASSERTION FAILED: !begin.isIndefinite() in WebCore::SVGSMILElement::resolveFirstInterval

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 258753003: ASSERTION FAILED: !begin.isIndefinite() in WebCore::SVGSMILElement::resolveFirstInterval (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/animation/SVGSMILElement.cpp

diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp

index c61592205ce809fa6775bf11fa8510fbf11abcdf..5d7b72ebe5eaf41d2b0d76a6b44d2c11959052d7 100644

--- a/Source/core/svg/animation/SVGSMILElement.cpp

+++ b/Source/core/svg/animation/SVGSMILElement.cpp

@@ -773,7 +773,7 @@ SMILTime SVGSMILElement::maxValue() const

return m_cachedMax;

const AtomicString& value = fastGetAttribute(SVGNames::maxAttr);

SMILTime result = parseClockValue(value);

- return m_cachedMax = (result.isUnresolved() || result < 0) ? SMILTime::indefinite() : result;

+ return m_cachedMax = (result.isUnresolved() || result <= 0) ? SMILTime::indefinite() : result;

}

SMILTime SVGSMILElement::minValue() const

« no previous file with comments | « LayoutTests/svg/animations/smil-animation-max-attribute-zero-crash-expected.txt ('k') | no next file » | no next file with comments »