Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 258753003: ASSERTION FAILED: !begin.isIndefinite() in WebCore::SVGSMILElement::resolveFirstInterval (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/svg/animations/smil-animation-max-attribute-zero-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 755 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 m_cachedRepeatCount = computedRepeatCount; 766 m_cachedRepeatCount = computedRepeatCount;
767 return m_cachedRepeatCount; 767 return m_cachedRepeatCount;
768 } 768 }
769 769
770 SMILTime SVGSMILElement::maxValue() const 770 SMILTime SVGSMILElement::maxValue() const
771 { 771 {
772 if (m_cachedMax != invalidCachedTime) 772 if (m_cachedMax != invalidCachedTime)
773 return m_cachedMax; 773 return m_cachedMax;
774 const AtomicString& value = fastGetAttribute(SVGNames::maxAttr); 774 const AtomicString& value = fastGetAttribute(SVGNames::maxAttr);
775 SMILTime result = parseClockValue(value); 775 SMILTime result = parseClockValue(value);
776 return m_cachedMax = (result.isUnresolved() || result < 0) ? SMILTime::indef inite() : result; 776 return m_cachedMax = (result.isUnresolved() || result <= 0) ? SMILTime::inde finite() : result;
777 } 777 }
778 778
779 SMILTime SVGSMILElement::minValue() const 779 SMILTime SVGSMILElement::minValue() const
780 { 780 {
781 if (m_cachedMin != invalidCachedTime) 781 if (m_cachedMin != invalidCachedTime)
782 return m_cachedMin; 782 return m_cachedMin;
783 const AtomicString& value = fastGetAttribute(SVGNames::minAttr); 783 const AtomicString& value = fastGetAttribute(SVGNames::minAttr);
784 SMILTime result = parseClockValue(value); 784 SMILTime result = parseClockValue(value);
785 return m_cachedMin = (result.isUnresolved() || result < 0) ? 0 : result; 785 return m_cachedMin = (result.isUnresolved() || result < 0) ? 0 : result;
786 } 786 }
(...skipping 535 matching lines...) Expand 10 before | Expand all | Expand 10 after
1322 if (eventType == "repeatn") { 1322 if (eventType == "repeatn") {
1323 unsigned repeatEventCount = m_repeatEventCountList.first(); 1323 unsigned repeatEventCount = m_repeatEventCountList.first();
1324 m_repeatEventCountList.remove(0); 1324 m_repeatEventCountList.remove(0);
1325 dispatchEvent(RepeatEvent::create(eventType, repeatEventCount)); 1325 dispatchEvent(RepeatEvent::create(eventType, repeatEventCount));
1326 } else { 1326 } else {
1327 dispatchEvent(Event::create(eventType)); 1327 dispatchEvent(Event::create(eventType));
1328 } 1328 }
1329 } 1329 }
1330 1330
1331 } 1331 }
OLDNEW
« no previous file with comments | « LayoutTests/svg/animations/smil-animation-max-attribute-zero-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698