Use xvfb with Ozone CrOS.

Use xvfb with Ozone CrOS.

We want to switch the majority of Ozone CrOS tests over to run with
--ozone-platform=x11. This requires that test targets with type
'windowed_test_launcher' run using xvfb.

Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
step, which requires adding a new target for each test we want to add.
Instead, just assume that if use_ozone=true and target_os="chromeos"
then we want to use xvfb.

Ozone CrOS test with type 'windowed_test_launcher' will still need to
have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
run with Ozone X11. Once most tests pass under with Ozone X11 the
default Ozone platform can be swapped to be x11 and only tests that
should run with headless will require an args entry there.

BUG=671355
Committed: https://crrev.com/ed64274506538a9770b7bf86df7eef2ecb4948b7
Cr-Commit-Position: refs/heads/master@{#439557}

[kylechar, 2016-12-16 17:40:13]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 17:40:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2016-12-16 19:24:26]

Description was changed from

==========
Use xvfb with Ozone CrOS.

We want to switch the majority of Ozone CrOS tests over to run with
--ozone-platform=x11. This requires that test targets with type
'windowed_test_launcher' run using XVFB.

Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
step, which requires adding a new target for each test we want to add.
Instead, just assume that if use_ozone=true and target_os="chromeos"
then we want to use XVFB.

BUG=671355
==========

to

==========
Use xvfb with Ozone CrOS.

We want to switch the majority of Ozone CrOS tests over to run with
--ozone-platform=x11. This requires that test targets with type
'windowed_test_launcher' run using XVFB.

Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
step, which requires adding a new target for each test we want to add.
Instead, just assume that if use_ozone=true and target_os="chromeos"
then we want to use XVFB.

Ozone CrOS test with type 'windowed_test_launcher' will still need to
have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
run with Ozone X11. Once most tests pass under with Ozone X11 the
default Ozone platform can be swapped to be x11 and only tests that
should run with headless will require an args entry there.

BUG=671355
==========

[commit-bot: I haz the power, 2016-12-16 19:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 19:24:49]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-12-19 15:12:09]

Description was changed from

==========
Use xvfb with Ozone CrOS.

We want to switch the majority of Ozone CrOS tests over to run with
--ozone-platform=x11. This requires that test targets with type
'windowed_test_launcher' run using XVFB.

Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
step, which requires adding a new target for each test we want to add.
Instead, just assume that if use_ozone=true and target_os="chromeos"
then we want to use XVFB.

Ozone CrOS test with type 'windowed_test_launcher' will still need to
have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
run with Ozone X11. Once most tests pass under with Ozone X11 the
default Ozone platform can be swapped to be x11 and only tests that
should run with headless will require an args entry there.

BUG=671355
==========

to

==========
Use xvfb with Ozone CrOS.

We want to switch the majority of Ozone CrOS tests over to run with
--ozone-platform=x11. This requires that test targets with type
'windowed_test_launcher' run using xvfb.

Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
step, which requires adding a new target for each test we want to add.
Instead, just assume that if use_ozone=true and target_os="chromeos"
then we want to use xvfb.

Ozone CrOS test with type 'windowed_test_launcher' will still need to
have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
run with Ozone X11. Once most tests pass under with Ozone X11 the
default Ozone platform can be swapped to be x11 and only tests that
should run with headless will require an args entry there.

BUG=671355
==========

[kylechar, 2016-12-19 15:14:11]

kylechar@chromium.org changed reviewers:
+ dpranke@chromium.org, rjkroege@chromium.org, sadrul@chromium.org

[kylechar, 2016-12-19 15:22:36]

+drpanke for testing/buildbot/* and tools/mb/mb.py OWNERS / general review
+rjkroege as FYI / general review
+sadrul for ui/gl/BUILD.gn OWNERS

I don't think there are any use_ozone=true && target_os="chromeos" trybots we
wouldn't want to flip over to Ozone X11 by default. I could be missing something
though.

My other thought was if we could add some dictionary entry to mb_config.pyl for
the trybots that we want to run with Ozone X11 by default (and thus should use
xvfb for type=windowed_test_launcher).

[Dirk Pranke, 2016-12-19 17:43:59]

looks fine. lgtm.

[kylechar, 2016-12-19 17:47:22]

+thomasanderson FYI.

[sadrul, 2016-12-19 17:51:28]

cool! rs lgtm

[rjkroege, 2016-12-19 19:49:15]

lgtm

[kylechar, 2016-12-19 19:50:02]

Thanks!

[kylechar, 2016-12-19 19:50:05]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-12-19 19:50:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 21:10:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482177005679960,
"parent_rev": "39ebc6669cc01ac0227993ee6c5745f26b62d130", "commit_rev":
"376c882c386c00ceec658301c370853c1145ff38"}

[commit-bot: I haz the power, 2016-12-19 21:11:04]

Description was changed from

==========
Use xvfb with Ozone CrOS.

We want to switch the majority of Ozone CrOS tests over to run with
--ozone-platform=x11. This requires that test targets with type
'windowed_test_launcher' run using xvfb.

Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
step, which requires adding a new target for each test we want to add.
Instead, just assume that if use_ozone=true and target_os="chromeos"
then we want to use xvfb.

Ozone CrOS test with type 'windowed_test_launcher' will still need to
have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
run with Ozone X11. Once most tests pass under with Ozone X11 the
default Ozone platform can be swapped to be x11 and only tests that
should run with headless will require an args entry there.

BUG=671355
==========

to

==========
Use xvfb with Ozone CrOS.

We want to switch the majority of Ozone CrOS tests over to run with
--ozone-platform=x11. This requires that test targets with type
'windowed_test_launcher' run using xvfb.

Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
step, which requires adding a new target for each test we want to add.
Instead, just assume that if use_ozone=true and target_os="chromeos"
then we want to use xvfb.

Ozone CrOS test with type 'windowed_test_launcher' will still need to
have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
run with Ozone X11. Once most tests pass under with Ozone X11 the
default Ozone platform can be swapped to be x11 and only tests that
should run with headless will require an args entry there.

BUG=671355

Review-Url: https://codereview.chromium.org/2587473002
==========

[commit-bot: I haz the power, 2016-12-19 21:11:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-19 21:12:49]

Description was changed from

==========
Use xvfb with Ozone CrOS.

We want to switch the majority of Ozone CrOS tests over to run with
--ozone-platform=x11. This requires that test targets with type
'windowed_test_launcher' run using xvfb.

Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
step, which requires adding a new target for each test we want to add.
Instead, just assume that if use_ozone=true and target_os="chromeos"
then we want to use xvfb.

Ozone CrOS test with type 'windowed_test_launcher' will still need to
have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
run with Ozone X11. Once most tests pass under with Ozone X11 the
default Ozone platform can be swapped to be x11 and only tests that
should run with headless will require an args entry there.

BUG=671355

Review-Url: https://codereview.chromium.org/2587473002
==========

to

==========
Use xvfb with Ozone CrOS.

We want to switch the majority of Ozone CrOS tests over to run with
--ozone-platform=x11. This requires that test targets with type
'windowed_test_launcher' run using xvfb.

Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
step, which requires adding a new target for each test we want to add.
Instead, just assume that if use_ozone=true and target_os="chromeos"
then we want to use xvfb.

Ozone CrOS test with type 'windowed_test_launcher' will still need to
have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
run with Ozone X11. Once most tests pass under with Ozone X11 the
default Ozone platform can be swapped to be x11 and only tests that
should run with headless will require an args entry there.

BUG=671355

Committed: https://crrev.com/ed64274506538a9770b7bf86df7eef2ecb4948b7
Cr-Commit-Position: refs/heads/master@{#439557}
==========

[commit-bot: I haz the power, 2016-12-19 21:12:50]

Patchset 2 (id:??) landed as
https://crrev.com/ed64274506538a9770b7bf86df7eef2ecb4948b7
Cr-Commit-Position: refs/heads/master@{#439557}

[vmpstr, 2016-12-21 00:46:58]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2598483002/ by vmpstr@chromium.org.

The reason for reverting is: Suspecting that this is causing intermittent bot
crashes on after gl_unittests runs. See crbug.com/676128 for more details..