[runtime] Collect IC feedback in DefineDataPropertyInLiteral.

[runtime] Collect IC feedback in DefineDataPropertyInLiteral.

Add a feedback vector slot for computed property names in object 
and class literals. Introduce new slot kind for storing 
computed property names.

Change StaDataPropertyInLiteral to use the accumulator (again), so 
we don't exceed Bytecodes::kMaxOperands.

We assume that most computed property names are 
symbols. Therefore we should see performance 
improvements, even if we deal with monomorphic ICs only. 

This CL only collects feedback but does not use 
it in Reduce() yet.

BUG=v8:5624
Review-Url: https://codereview.chromium.org/2587393006
Cr-Commit-Position: refs/heads/master@{#42082}
Committed: https://chromium.googlesource.com/v8/v8/+/81736c7161cf07d6baa2573d6bf5c9a1603a4dab

[Franzi, 2016-12-21 17:31:45]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 17:31:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 17:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 17:33:04]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/18255)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14672)

[Franzi, 2016-12-21 17:43:50]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 17:43:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 17:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 17:50:43]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Franzi, 2016-12-21 19:00:30]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 19:00:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 19:07:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 19:07:09]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Franzi, 2017-01-02 16:00:17]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-02 16:00:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-02 16:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-02 16:07:01]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Franzi, 2017-01-03 14:12:01]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 14:12:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 14:31:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 14:31:36]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[Franzi, 2017-01-03 15:59:58]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 16:00:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 16:36:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 16:36:48]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/18592)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Franzi, 2017-01-04 10:51:49]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 10:52:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 11:20:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 11:20:18]

Dry run: This issue passed the CQ dry run.

[Franzi, 2017-01-04 12:16:00]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 12:16:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2017-01-04 12:57:42]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 12:57:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2017-01-04 13:09:46]

Description was changed from

==========
[interpreter] WIP Add feedback slot to DataPropertyInLiteral.

Work in progress. Add feedback slot index to DataPropertyInLiteral.

BUG=v8:5624
==========

to

==========
[runtime] Collect IC feedback in DefineDataPropertyInLiteral.

Add a feedback vector slot for computed property names in object and class
literals. Introduce new slot kind for storing computed property names.

Change StaDataPropertyInLiteral to use the accumulator (again), so we don't
exceed Bytecodes::kMaxOperands.

We assume that most computed property names are symbols. Therefore we should see
performance improvements, even if we deal with monomorphic ICs only. 

This CL only collects feedback but does not use it in Reduce() yet.

BUG=v8:5624
==========

[Franzi, 2017-01-04 13:09:47]

franzih@chromium.org changed reviewers:
+ mvstanton@chromium.org

[Franzi, 2017-01-04 13:10:55]

Description was changed from

==========
[runtime] Collect IC feedback in DefineDataPropertyInLiteral.

Add a feedback vector slot for computed property names in object and class
literals. Introduce new slot kind for storing computed property names.

Change StaDataPropertyInLiteral to use the accumulator (again), so we don't
exceed Bytecodes::kMaxOperands.

We assume that most computed property names are symbols. Therefore we should see
performance improvements, even if we deal with monomorphic ICs only. 

This CL only collects feedback but does not use it in Reduce() yet.

BUG=v8:5624
==========

to

==========
[runtime] Collect IC feedback in DefineDataPropertyInLiteral.

Add a feedback vector slot for computed property names in object 
and class literals. Introduce new slot kind for storing 
computed property names.

Change StaDataPropertyInLiteral to use the accumulator (again), so 
we don't exceed Bytecodes::kMaxOperands.

We assume that most computed property names are 
symbols. Therefore we should see performance 
improvements, even if we deal with monomorphic ICs only. 

This CL only collects feedback but does not use 
it in Reduce() yet.

BUG=v8:5624
==========

[Franzi, 2017-01-04 13:12:39]

Hi Michael, 

Please take a look.

Thanks, 

Franzi

[commit-bot: I haz the power, 2017-01-04 13:26:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 13:26:19]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-01-04 14:21:47]

LGTM, thanks!

https://codereview.chromium.org/2587393006/diff/160001/src/interpreter/byteco...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2587393006/diff/160001/src/interpreter/byteco...
src/interpreter/bytecode-generator.cc:1759:
FunctionLiteral::NeedsHomeObject(property->value()) ? 1 : 0);
nit: It occurs to me how sad it is to have to pepper the world with
"NeedsHomeObject". Is it possible to make GetSlot() return the correct answer
(hiding NeedsHomeObject inside)?

[Franzi, 2017-01-04 14:45:02]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 14:45:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2017-01-04 14:51:09]

https://codereview.chromium.org/2587393006/diff/160001/src/interpreter/byteco...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2587393006/diff/160001/src/interpreter/byteco...
src/interpreter/bytecode-generator.cc:1759:
FunctionLiteral::NeedsHomeObject(property->value()) ? 1 : 0);
On 2017/01/04 14:21:47, mvstanton wrote:
> nit: It occurs to me how sad it is to have to pepper the world with
> "NeedsHomeObject". Is it possible to make GetSlot() return the correct answer
> (hiding NeedsHomeObject inside)?
> 

You're right. Hiding the offset in Set/GetStoreDataPropertySlot() in
LiteralProperty now.

[commit-bot: I haz the power, 2017-01-04 15:13:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 15:13:11]

Dry run: This issue passed the CQ dry run.

[Franzi, 2017-01-04 22:51:45]

The CQ bit was checked by franzih@chromium.org

[Franzi, 2017-01-04 22:51:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/2587393006/#ps180001
(title: "Add Get/SetSlot function for StoreDataProp.")

[commit-bot: I haz the power, 2017-01-04 22:51:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 22:55:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 22:55:06]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/31682)

[Franzi, 2017-01-05 06:42:19]

The CQ bit was checked by franzih@chromium.org

[Franzi, 2017-01-05 06:42:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/2587393006/#ps200001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-05 06:42:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 06:46:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 06:46:20]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/31701)

[Benedikt Meurer, 2017-01-05 06:52:19]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2017-01-05 06:52:20]

LGTM.

[Franzi, 2017-01-05 06:52:42]

The CQ bit was checked by franzih@chromium.org

[commit-bot: I haz the power, 2017-01-05 06:52:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 07:30:03]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1483599162418210,
"parent_rev": "c4e0b1598148613963925846ef05184245cd8b53", "commit_rev":
"81736c7161cf07d6baa2573d6bf5c9a1603a4dab"}

[commit-bot: I haz the power, 2017-01-05 07:30:08]

Description was changed from

==========
[runtime] Collect IC feedback in DefineDataPropertyInLiteral.

Add a feedback vector slot for computed property names in object 
and class literals. Introduce new slot kind for storing 
computed property names.

Change StaDataPropertyInLiteral to use the accumulator (again), so 
we don't exceed Bytecodes::kMaxOperands.

We assume that most computed property names are 
symbols. Therefore we should see performance 
improvements, even if we deal with monomorphic ICs only. 

This CL only collects feedback but does not use 
it in Reduce() yet.

BUG=v8:5624
==========

to

==========
[runtime] Collect IC feedback in DefineDataPropertyInLiteral.

Add a feedback vector slot for computed property names in object 
and class literals. Introduce new slot kind for storing 
computed property names.

Change StaDataPropertyInLiteral to use the accumulator (again), so 
we don't exceed Bytecodes::kMaxOperands.

We assume that most computed property names are 
symbols. Therefore we should see performance 
improvements, even if we deal with monomorphic ICs only. 

This CL only collects feedback but does not use 
it in Reduce() yet.

BUG=v8:5624

Review-Url: https://codereview.chromium.org/2587393006
Cr-Commit-Position: refs/heads/master@{#42082}
Committed:
https://chromium.googlesource.com/v8/v8/+/81736c7161cf07d6baa2573d6bf5c9a1603...
==========

[commit-bot: I haz the power, 2017-01-05 07:30:13]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/v8/v8/+/81736c7161cf07d6baa2573d6bf5c9a1603...