[runtime] Collect IC feedback in DefineDataPropertyInLiteral.

src/interpreter/bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecode-generator.h"
 
 #include "src/ast/compile-time-value.h"
 #include "src/ast/scopes.h"
 #include "src/builtins/builtins-constructor.h"
 #include "src/code-stubs.h"
@@ skipping 1487 matching lines @@
           .StoreAccumulatorInRegister(attr);
       attr_assigned = true;
     }
 
     switch (property->kind()) {
       case ClassLiteral::Property::METHOD: {
         DataPropertyInLiteralFlags flags = DataPropertyInLiteralFlag::kDontEnum;
         if (property->NeedsSetFunctionName()) {
           flags |= DataPropertyInLiteralFlag::kSetFunctionName;
         }
-        builder()->StoreDataPropertyInLiteral(receiver, key, value, flags);
+
+        FeedbackVectorSlot slot = property->GetSlot(
+            FunctionLiteral::NeedsHomeObject(property->value()) ? 1 : 0);
+        DCHECK(!slot.IsInvalid());
+
+        builder()
+            ->LoadAccumulatorWithRegister(value)
+            .StoreDataPropertyInLiteral(receiver, key, flags,
+                                        feedback_index(slot));
         break;
       }
       case ClassLiteral::Property::GETTER: {
         builder()->CallRuntime(Runtime::kDefineGetterPropertyUnchecked, args);
         break;
       }
       case ClassLiteral::Property::SETTER: {
         builder()->CallRuntime(Runtime::kDefineSetterPropertyUnchecked, args);
         break;
       }
@@ skipping 221 matching lines @@
 
         Register value = VisitForRegisterValue(property->value());
         VisitSetHomeObject(value, literal, property);
 
         DataPropertyInLiteralFlags data_property_flags =
             DataPropertyInLiteralFlag::kNoFlags;
         if (property->NeedsSetFunctionName()) {
           data_property_flags |= DataPropertyInLiteralFlag::kSetFunctionName;
         }
 
-        builder()->StoreDataPropertyInLiteral(literal, key, value,
-                                              data_property_flags);
+        FeedbackVectorSlot slot = property->GetSlot(
+            FunctionLiteral::NeedsHomeObject(property->value()) ? 1 : 0);

[mvstanton, 2017/01/04 14:21:47]

nit: It occurs to me how sad it is to have to pepper the world with
"NeedsHomeObject". Is it possible to make GetSlot() return the correct answer
(hiding NeedsHomeObject inside)?

[Franzi, 2017/01/04 14:51:09]

You're right. Hiding the offset in Set/GetStoreDataPropertySlot() in
LiteralProperty now. 

+        DCHECK(!slot.IsInvalid());
+
+        builder()
+            ->LoadAccumulatorWithRegister(value)
+            .StoreDataPropertyInLiteral(literal, key, data_property_flags,
+                                        feedback_index(slot));
         break;
       }
       case ObjectLiteral::Property::GETTER:
       case ObjectLiteral::Property::SETTER: {
         RegisterList args = register_allocator()->NewRegisterList(4);
         builder()->MoveRegister(literal, args[0]);
         VisitForAccumulatorValue(property->key());
         builder()->ConvertAccumulatorToName(args[1]);
         VisitForRegisterValue(property->value(), args[2]);
         VisitSetHomeObject(args[2], literal, property);
@@ skipping 1547 matching lines @@
 }
 
 Runtime::FunctionId BytecodeGenerator::StoreKeyedToSuperRuntimeId() {
   return is_strict(language_mode()) ? Runtime::kStoreKeyedToSuper_Strict
                                     : Runtime::kStoreKeyedToSuper_Sloppy;
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8