Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2587373002: Revert of [runtime] Add fast-paths for common conversion methods (Closed)

Created:
4 years ago by Camillo Bruni
Modified:
4 years ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [runtime] Add fast-paths for common conversion methods (patchset #1 id:1 of https://codereview.chromium.org/2587013002/ ) Reason for revert: breaks mips port: http://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/6131 Original issue's description: > [runtime] Add fast-paths for common conversion methods > > Add inlineable fast-paths for Object::ToPropertyKey, Object::ToLength and > Object::ToIndex for the most common argument types. > > BUG= > > Review-Url: https://codereview.chromium.org/2587013002 > Cr-Commit-Position: refs/heads/master@{#41839} > Committed: https://chromium.googlesource.com/v8/v8/+/d173807b9d8cb3c4cc4ee9c94c5cc960224b2c40 TBR=jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2587373002 Cr-Commit-Position: refs/heads/master@{#41845} Committed: https://chromium.googlesource.com/v8/v8/+/608df93382ce4186ffc0539967e3ea7cdff6cddf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -73 lines) Patch
M src/objects.h View 3 chunks +4 lines, -12 lines 0 comments Download
M src/objects.cc View 4 chunks +32 lines, -37 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/regexp/regexp-utils.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Camillo Bruni
Created Revert of [runtime] Add fast-paths for common conversion methods
4 years ago (2016-12-20 10:14:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587373002/1
4 years ago (2016-12-20 10:14:19 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-20 10:14:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/608df93382ce4186ffc0539967e3ea7cdff...

Powered by Google App Engine
This is Rietveld 408576698