Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2587013002: [runtime] Add fast-paths for common conversion methods (Closed)

Created:
4 years ago by Camillo Bruni
Modified:
4 years ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Add fast-paths for common conversion methods Add inlineable fast-paths for Object::ToPropertyKey, Object::ToLength and Object::ToIndex for the most common argument types. BUG= Review-Url: https://codereview.chromium.org/2587013002 Cr-Commit-Position: refs/heads/master@{#41856} Committed: https://chromium.googlesource.com/v8/v8/+/1e56813f48c74c88679c7c3f74612f2aedf1011a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -38 lines) Patch
M src/objects.h View 3 chunks +12 lines, -4 lines 0 comments Download
M src/objects.cc View 4 chunks +37 lines, -32 lines 0 comments Download
M src/objects-inl.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/regexp/regexp-utils.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Camillo Bruni
PTAL
4 years ago (2016-12-19 13:48:30 UTC) #5
jgruber
Nice, lgtm!
4 years ago (2016-12-20 07:40:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587013002/1
4 years ago (2016-12-20 09:48:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/d173807b9d8cb3c4cc4ee9c94c5cc960224b2c40
4 years ago (2016-12-20 09:50:38 UTC) #13
Camillo Bruni
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2587373002/ by cbruni@chromium.org. ...
4 years ago (2016-12-20 10:14:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587013002/1
4 years ago (2016-12-20 12:19:02 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-20 12:21:07 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1e56813f48c74c88679c7c3f74612f2aedf...

Powered by Google App Engine
This is Rietveld 408576698