Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2587323004: ScriptPromisePropertyBase should use ContextClient instead of ContextLifecycleObserver (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ScriptPromisePropertyBase should use ContextClient instead of ContextLifecycleObserver ScriptPromisePropertyBase doesn't need to observe contextDestroyed. So ContextClient is enough and more efficient. BUG=610176 Committed: https://crrev.com/28a790f8946476da715d9ba72406f1dce462906b Cr-Commit-Position: refs/heads/master@{#440087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL (Essentially this is a reland of https://codereview.chromium.org/2555873004/ in a different style.)
4 years ago (2016-12-21 12:28:28 UTC) #2
sof
lgtm The WeakMember<> preventing the leaks of the previous attempt, i hope.
4 years ago (2016-12-21 12:30:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587323004/1
4 years ago (2016-12-21 12:35:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 14:03:57 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-21 14:06:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28a790f8946476da715d9ba72406f1dce462906b
Cr-Commit-Position: refs/heads/master@{#440087}

Powered by Google App Engine
This is Rietveld 408576698