third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h - Issue 2587323004: ScriptPromisePropertyBase should use ContextClient instead of ContextLifecycleObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

Issue 2587323004: ScriptPromisePropertyBase should use ContextClient instead of ContextLifecycleObserver (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

index ef03a45b31bb914664a089bd21855a80f46bbf62..8c359827242e034dc521c3e3d3009d19ff8ebe13 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

@@ -25,7 +25,7 @@ class ScriptState;

// TODO(yhirano): Remove NEVER_INLINE once we find the cause of crashes.

class CORE_EXPORT ScriptPromisePropertyBase

: public GarbageCollectedFinalized<ScriptPromisePropertyBase>,

- public ContextLifecycleObserver {

+ public ContextClient {

USING_GARBAGE_COLLECTED_MIXIN(ScriptPromisePropertyBase);

public:

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp » ('j') | no next file with comments »