FormFetcherImpl: MakeWeakCopies no longer a template

FormFetcherImpl: MakeWeakCopies no longer a template

MakeWeakCopies is a helper function inside the FormFetcherImpl implementation.
It transforms a vector of unique_ptrs into the result of calling get() on them.
It used to be used for pointers of different types, therefore it was a function
template. But after https://codereview.chromium.org/2552263002, MakeWeakCopies
is only used with PasswordForms.

This CL:
 * Converts MakeWeakCopies to a simple function.
 * Removes some unnecessary "autofill::" in the same file.

BUG=621355
R=vasilii@chromium.org

Committed: https://crrev.com/a97b4417b06a86a4f006e4a06979817d3e552015
Cr-Commit-Position: refs/heads/master@{#439795}

[vabr (Chromium), 2016-12-20 07:03:01]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 07:03:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 08:05:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 08:05:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2016-12-20 10:39:48]

Hi Vasilii,

Please review.

Thanks!
Vaclav

[vasilii, 2016-12-20 11:00:06]

lgtm

https://codereview.chromium.org/2587313002/diff/1/components/password_manager...
File components/password_manager/core/browser/form_fetcher_impl.cc (right):

https://codereview.chromium.org/2587313002/diff/1/components/password_manager...
components/password_manager/core/browser/form_fetcher_impl.cc:53:
result.resize(owning.size());
Combine those lines into 
std::vector<const PasswordForm*> result(owning.size());

[vabr (Chromium), 2016-12-20 13:36:27]

Thanks!

https://codereview.chromium.org/2587313002/diff/1/components/password_manager...
File components/password_manager/core/browser/form_fetcher_impl.cc (right):

https://codereview.chromium.org/2587313002/diff/1/components/password_manager...
components/password_manager/core/browser/form_fetcher_impl.cc:53:
result.resize(owning.size());
On 2016/12/20 11:00:06, vasilii wrote:
> Combine those lines into 
> std::vector<const PasswordForm*> result(owning.size());	

Done.

[vabr (Chromium), 2016-12-20 13:36:30]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-12-20 13:36:31]

The patchset sent to the CQ was uploaded after l-g-t-m from vasilii@chromium.org
Link to the patchset: https://codereview.chromium.org/2587313002/#ps20001
(title: "resize -> constructor")

[commit-bot: I haz the power, 2016-12-20 13:36:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 14:22:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482240990665480,
"parent_rev": "fa6a82bcd938bccb8cd97783a1d9cb93eddbe474", "commit_rev":
"692950c734d59d751517c4cd84e3480cdca3a5b9"}

[commit-bot: I haz the power, 2016-12-20 14:22:56]

Description was changed from

==========
FormFetcherImpl: MakeWeakCopies no longer a template

MakeWeakCopies is a helper function inside the FormFetcherImpl implementation.
It transforms a vector of unique_ptrs into the result of calling get() on them.
It used to be used for pointers of different types, therefore it was a function
template. But after https://codereview.chromium.org/2552263002, MakeWeakCopies
is only used with PasswordForms.

This CL:
 * Converts MakeWeakCopies to a simple function.
 * Removes some unnecessary "autofill::" in the same file.

BUG=621355
R=vasilii@chromium.org
==========

to

==========
FormFetcherImpl: MakeWeakCopies no longer a template

MakeWeakCopies is a helper function inside the FormFetcherImpl implementation.
It transforms a vector of unique_ptrs into the result of calling get() on them.
It used to be used for pointers of different types, therefore it was a function
template. But after https://codereview.chromium.org/2552263002, MakeWeakCopies
is only used with PasswordForms.

This CL:
 * Converts MakeWeakCopies to a simple function.
 * Removes some unnecessary "autofill::" in the same file.

BUG=621355
R=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2587313002
==========

[commit-bot: I haz the power, 2016-12-20 14:22:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 14:25:39]

Description was changed from

==========
FormFetcherImpl: MakeWeakCopies no longer a template

MakeWeakCopies is a helper function inside the FormFetcherImpl implementation.
It transforms a vector of unique_ptrs into the result of calling get() on them.
It used to be used for pointers of different types, therefore it was a function
template. But after https://codereview.chromium.org/2552263002, MakeWeakCopies
is only used with PasswordForms.

This CL:
 * Converts MakeWeakCopies to a simple function.
 * Removes some unnecessary "autofill::" in the same file.

BUG=621355
R=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2587313002
==========

to

==========
FormFetcherImpl: MakeWeakCopies no longer a template

MakeWeakCopies is a helper function inside the FormFetcherImpl implementation.
It transforms a vector of unique_ptrs into the result of calling get() on them.
It used to be used for pointers of different types, therefore it was a function
template. But after https://codereview.chromium.org/2552263002, MakeWeakCopies
is only used with PasswordForms.

This CL:
 * Converts MakeWeakCopies to a simple function.
 * Removes some unnecessary "autofill::" in the same file.

BUG=621355
R=vasilii@chromium.org

Committed: https://crrev.com/a97b4417b06a86a4f006e4a06979817d3e552015
Cr-Commit-Position: refs/heads/master@{#439795}
==========

[commit-bot: I haz the power, 2016-12-20 14:25:39]

Patchset 2 (id:??) landed as
https://crrev.com/a97b4417b06a86a4f006e4a06979817d3e552015
Cr-Commit-Position: refs/heads/master@{#439795}