DevTools: teach TabbedPane.setTabIcon to accept UI.Icon instances

DevTools: teach TabbedPane.setTabIcon to accept UI.Icon instances

This patch is a preparation for a "badged icons" instead of green
checkmarks in the "persistence2" experiment.

Currently, TabbedPane.setTabIcon method accepts icon type and icon
titles. This works fine, but we'd like to pass in a more complex
objects - badged icons.

For this to work, the TabbedPane.setTabIcon has to accept general
instances of UI.Icon class.

BUG=675856
R=dgozman

Committed: https://crrev.com/911cf4b74f6dbce780c83e31b51358bb2c849416
Cr-Commit-Position: refs/heads/master@{#439828}

[lushnikov, 2016-12-20 05:36:05]

please, take a look

https://codereview.chromium.org/2587293002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css (right):

https://codereview.chromium.org/2587293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css:76: margin-right:
6px;
6px = 2px (old) + 4px (from dt-label)

[dgozman, 2016-12-20 05:42:04]

lgtm

https://codereview.chromium.org/2587293002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js (right):

https://codereview.chromium.org/2587293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js:175:
setPanelIcon(panelName, iconType, iconTooltip) {
Let's change this one to accept Icon instead.

[lushnikov, 2016-12-20 06:52:10]

https://codereview.chromium.org/2587293002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js (right):

https://codereview.chromium.org/2587293002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js:175:
setPanelIcon(panelName, iconType, iconTooltip) {
On 2016/12/20 05:42:04, dgozman wrote:
> Let's change this one to accept Icon instead.

Done.

[lushnikov, 2016-12-20 06:52:16]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-12-20 06:52:16]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2587293002/#ps20001
(title: "formatting")

[commit-bot: I haz the power, 2016-12-20 06:52:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 07:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 07:50:38]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[lushnikov, 2016-12-20 15:45:22]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-12-20 15:45:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 16:57:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482248722023680,
"parent_rev": "16b06b430bad4788d88736963a724d71632fe4ab", "commit_rev":
"3cd66be714fda8cda4cfd0451bdbd168a2bac3f4"}

[commit-bot: I haz the power, 2016-12-20 16:58:26]

Description was changed from

==========
DevTools: teach TabbedPane.setTabIcon to accept UI.Icon instances

This patch is a preparation for a "badged icons" instead of green
checkmarks in the "persistence2" experiment.

Currently, TabbedPane.setTabIcon method accepts icon type and icon
titles. This works fine, but we'd like to pass in a more complex
objects - badged icons.

For this to work, the TabbedPane.setTabIcon has to accept general
instances of UI.Icon class.

BUG=675856
R=dgozman
==========

to

==========
DevTools: teach TabbedPane.setTabIcon to accept UI.Icon instances

This patch is a preparation for a "badged icons" instead of green
checkmarks in the "persistence2" experiment.

Currently, TabbedPane.setTabIcon method accepts icon type and icon
titles. This works fine, but we'd like to pass in a more complex
objects - badged icons.

For this to work, the TabbedPane.setTabIcon has to accept general
instances of UI.Icon class.

BUG=675856
R=dgozman

Review-Url: https://codereview.chromium.org/2587293002
==========

[commit-bot: I haz the power, 2016-12-20 16:58:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 17:01:31]

Description was changed from

==========
DevTools: teach TabbedPane.setTabIcon to accept UI.Icon instances

This patch is a preparation for a "badged icons" instead of green
checkmarks in the "persistence2" experiment.

Currently, TabbedPane.setTabIcon method accepts icon type and icon
titles. This works fine, but we'd like to pass in a more complex
objects - badged icons.

For this to work, the TabbedPane.setTabIcon has to accept general
instances of UI.Icon class.

BUG=675856
R=dgozman

Review-Url: https://codereview.chromium.org/2587293002
==========

to

==========
DevTools: teach TabbedPane.setTabIcon to accept UI.Icon instances

This patch is a preparation for a "badged icons" instead of green
checkmarks in the "persistence2" experiment.

Currently, TabbedPane.setTabIcon method accepts icon type and icon
titles. This works fine, but we'd like to pass in a more complex
objects - badged icons.

For this to work, the TabbedPane.setTabIcon has to accept general
instances of UI.Icon class.

BUG=675856
R=dgozman

Committed: https://crrev.com/911cf4b74f6dbce780c83e31b51358bb2c849416
Cr-Commit-Position: refs/heads/master@{#439828}
==========

[commit-bot: I haz the power, 2016-12-20 17:01:32]

Patchset 2 (id:??) landed as
https://crrev.com/911cf4b74f6dbce780c83e31b51358bb2c849416
Cr-Commit-Position: refs/heads/master@{#439828}