third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js - Issue 2587293002: DevTools: teach TabbedPane.setTabIcon to accept UI.Icon instances

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

Issue 2587293002: DevTools: teach TabbedPane.setTabIcon to accept UI.Icon instances (Closed)

Patch Set: formatting Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js b/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

index ed3add080ab9696f3a643893c1c6eea70156f761..1a8526d8fe07500c1734acd0ba6a79c024f6e34c 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

@@ -533,17 +533,16 @@ Sources.TabbedEditorContainer = class extends Common.Object {

if (tabId) {

var title = this._titleForFile(uiSourceCode);

this._tabbedPane.changeTabTitle(tabId, title);

+ var icon = null;

if (Persistence.persistence.hasUnsavedCommittedChanges(uiSourceCode)) {

- this._tabbedPane.setTabIcon(

- tabId, 'smallicon-warning', Common.UIString('Changes to this file were not saved to file system.'));

+ icon = UI.Icon.create('smallicon-warning');

+ icon.title = Common.UIString('Changes to this file were not saved to file system.');

} else if (Runtime.experiments.isEnabled('persistence2') && Persistence.persistence.binding(uiSourceCode)) {

var binding = Persistence.persistence.binding(uiSourceCode);

- this._tabbedPane.setTabIcon(

- tabId, 'smallicon-green-checkmark',

- Persistence.PersistenceUtils.tooltipForUISourceCode(binding.fileSystem));

- } else {

- this._tabbedPane.setTabIcon(tabId, '');

+ icon = UI.Icon.create('smallicon-green-checkmark');

+ icon.title = Persistence.PersistenceUtils.tooltipForUISourceCode(binding.fileSystem);

}

+ this._tabbedPane.setTabIcon(tabId, icon);

}