[layoutng] Add a shrink-to-fit flag to the constraint space

[layoutng] Add a shrink-to-fit flag to the constraint space

This is useful for a few things:
- A way to communicate from the layout algorithm to ng_length_utils that we
  should treat auto as shrink-to-fit. There's no good other way to do this --
  ng_length_utils gets the logicalWidth() property directly and needs to know
  to treat it specially.
  Conversely I did not want to encode this knowledge inside of length utils
  because that gets complicated fast and puts special knowledge in a single
  place instead of distributing it to caller layout algorithms which are a
  much more natural spot.
- It allows a parent layout algorithm to tell a child box that it should shrink
  to fit even when it normally wouldn't, e.g. for flex items.

This is essentially a companion change to
https://codereview.chromium.org/2583033004/ -- with both these changes we
should correctly size inline-blocks and floats.

R=ikilpatrick@chromium.org
BUG=635619
Committed: https://crrev.com/aad3ca9d2bc90049564e97e956cc5ebbf9e8159b
Cr-Commit-Position: refs/heads/master@{#440344}

[cbiesinger, 2016-12-20 21:16:07]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 21:16:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 22:48:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 22:48:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cbiesinger, 2016-12-21 15:30:13]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 15:30:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-12-21 15:36:45]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 15:37:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-12-21 16:17:52]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 16:18:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 17:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 17:34:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cbiesinger, 2016-12-21 17:41:05]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 17:41:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 19:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 19:16:45]

Dry run: This issue passed the CQ dry run.

[ikilpatrick, 2016-12-22 00:06:14]

lgtm

https://codereview.chromium.org/2587283004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2587283004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:97: bool
HasForcedShrinkToFit() const { return has_forced_shrink_to_fit_; }
Comment explaining what this does? E.g.

Whether the child should shrink-to-fit if it's inline size is 'auto', instead of
taking up the inline available space.
E.g. this is used for floating, abs-pos, etc.

https://codereview.chromium.org/2587283004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:97: bool
HasForcedShrinkToFit() const { return has_forced_shrink_to_fit_; }
IsShrinkToFit? to keep in line with other bits?

[cbiesinger, 2016-12-22 03:34:13]

The CQ bit was checked by cbiesinger@chromium.org

[cbiesinger, 2016-12-22 03:34:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2587283004/#ps100001
(title: "review comments")

[cbiesinger, 2016-12-22 03:34:25]

https://codereview.chromium.org/2587283004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2587283004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:97: bool
HasForcedShrinkToFit() const { return has_forced_shrink_to_fit_; }
On 2016/12/22 00:06:14, ikilpatrick wrote:
> IsShrinkToFit? to keep in line with other bits?

Done (both).

[commit-bot: I haz the power, 2016-12-22 03:34:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 05:10:39]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482377653119190,
"parent_rev": "359aecbfd8ccae28239df2f067d2facf7fd23488", "commit_rev":
"52ad667b286cecdf88c75aedd4c71a893b2a181d"}

[commit-bot: I haz the power, 2016-12-22 05:11:38]

Description was changed from

==========
[layoutng] Add a shrink-to-fit flag to the constraint space

This is useful for a few things:
- A way to communicate from the layout algorithm to ng_length_utils that we
  should treat auto as shrink-to-fit. There's no good other way to do this --
  ng_length_utils gets the logicalWidth() property directly and needs to know
  to treat it specially.
  Conversely I did not want to encode this knowledge inside of length utils
  because that gets complicated fast and puts special knowledge in a single
  place instead of distributing it to caller layout algorithms which are a
  much more natural spot.
- It allows a parent layout algorithm to tell a child box that it should shrink
  to fit even when it normally wouldn't, e.g. for flex items.

This is essentially a companion change to
https://codereview.chromium.org/2583033004/ -- with both these changes we
should correctly size inline-blocks and floats.

R=ikilpatrick@chromium.org
BUG=635619
==========

to

==========
[layoutng] Add a shrink-to-fit flag to the constraint space

This is useful for a few things:
- A way to communicate from the layout algorithm to ng_length_utils that we
  should treat auto as shrink-to-fit. There's no good other way to do this --
  ng_length_utils gets the logicalWidth() property directly and needs to know
  to treat it specially.
  Conversely I did not want to encode this knowledge inside of length utils
  because that gets complicated fast and puts special knowledge in a single
  place instead of distributing it to caller layout algorithms which are a
  much more natural spot.
- It allows a parent layout algorithm to tell a child box that it should shrink
  to fit even when it normally wouldn't, e.g. for flex items.

This is essentially a companion change to
https://codereview.chromium.org/2583033004/ -- with both these changes we
should correctly size inline-blocks and floats.

R=ikilpatrick@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2587283004
==========

[commit-bot: I haz the power, 2016-12-22 05:11:39]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-22 05:13:51]

Description was changed from

==========
[layoutng] Add a shrink-to-fit flag to the constraint space

This is useful for a few things:
- A way to communicate from the layout algorithm to ng_length_utils that we
  should treat auto as shrink-to-fit. There's no good other way to do this --
  ng_length_utils gets the logicalWidth() property directly and needs to know
  to treat it specially.
  Conversely I did not want to encode this knowledge inside of length utils
  because that gets complicated fast and puts special knowledge in a single
  place instead of distributing it to caller layout algorithms which are a
  much more natural spot.
- It allows a parent layout algorithm to tell a child box that it should shrink
  to fit even when it normally wouldn't, e.g. for flex items.

This is essentially a companion change to
https://codereview.chromium.org/2583033004/ -- with both these changes we
should correctly size inline-blocks and floats.

R=ikilpatrick@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2587283004
==========

to

==========
[layoutng] Add a shrink-to-fit flag to the constraint space

This is useful for a few things:
- A way to communicate from the layout algorithm to ng_length_utils that we
  should treat auto as shrink-to-fit. There's no good other way to do this --
  ng_length_utils gets the logicalWidth() property directly and needs to know
  to treat it specially.
  Conversely I did not want to encode this knowledge inside of length utils
  because that gets complicated fast and puts special knowledge in a single
  place instead of distributing it to caller layout algorithms which are a
  much more natural spot.
- It allows a parent layout algorithm to tell a child box that it should shrink
  to fit even when it normally wouldn't, e.g. for flex items.

This is essentially a companion change to
https://codereview.chromium.org/2583033004/ -- with both these changes we
should correctly size inline-blocks and floats.

R=ikilpatrick@chromium.org
BUG=635619

Committed: https://crrev.com/aad3ca9d2bc90049564e97e956cc5ebbf9e8159b
Cr-Commit-Position: refs/heads/master@{#440344}
==========

[commit-bot: I haz the power, 2016-12-22 05:13:52]

Patchset 6 (id:??) landed as
https://crrev.com/aad3ca9d2bc90049564e97e956cc5ebbf9e8159b
Cr-Commit-Position: refs/heads/master@{#440344}