Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2583033004: [layoutng] Implement support for width: {min,max,fit}-content (Closed)

Created:
4 years ago by cbiesinger
Modified:
4 years ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Implement support for width: {min,max,fit}-content This also implements shrink-to-fit for inline-block and floats, which is now a one-line change. BUG=635619 R=ikilpatrick@chromium.org Committed: https://crrev.com/372351b102c692f8e35495c9dd4fce17b445aa12 Cr-Commit-Position: refs/heads/master@{#440447}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : compile error #

Total comments: 2

Patch Set 4 : rebased #

Patch Set 5 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -17 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 3 8 chunks +63 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 2 3 4 3 chunks +69 lines, -1 line 0 comments Download

Messages

Total messages: 22 (14 generated)
cbiesinger
4 years ago (2016-12-20 21:14:45 UTC) #1
ikilpatrick
lgtm, this along with abs-pos makes me want to rip out the state machines, and ...
4 years ago (2016-12-22 03:26:22 UTC) #10
ikilpatrick
https://codereview.chromium.org/2583033004/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc (right): https://codereview.chromium.org/2583033004/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc#newcode789 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc:789: style_->setWidth(Length(kWidth, Fixed)); shouldn't this be fit-content or similar to ...
4 years ago (2016-12-22 03:29:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583033004/80001
4 years ago (2016-12-22 15:22:14 UTC) #14
cbiesinger
https://codereview.chromium.org/2583033004/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc (right): https://codereview.chromium.org/2583033004/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc#newcode789 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc:789: style_->setWidth(Length(kWidth, Fixed)); On 2016/12/22 03:29:18, ikilpatrick wrote: > shouldn't ...
4 years ago (2016-12-22 15:22:32 UTC) #15
cbiesinger
On 2016/12/22 03:26:22, ikilpatrick wrote: > lgtm, > > this along with abs-pos makes me ...
4 years ago (2016-12-22 15:23:04 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-22 17:40:10 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-22 17:42:17 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/372351b102c692f8e35495c9dd4fce17b445aa12
Cr-Commit-Position: refs/heads/master@{#440447}

Powered by Google App Engine
This is Rietveld 408576698