Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2587233002: Make CFX_Observable copy constructable. (Closed)

Created:
4 years ago by Tom Sepez
Modified:
3 years, 11 months ago
Reviewers:
Lei Zhang, dsinclair, Wei Li, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make CFX_Observable copy constructable. Fix some naming to make things clearer. Review-Url: https://codereview.chromium.org/2587233002 Committed: https://pdfium.googlesource.com/pdfium/+/d0bbccdd32113baf95ae16565c0314166d989638

Patch Set 1 #

Patch Set 2 : better-test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -22 lines) Patch
M core/fxcrt/cfx_observable.h View 1 chunk +25 lines, -22 lines 0 comments Download
M core/fxcrt/cfx_observable_unittest.cpp View 1 2 chunks +72 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Tom Sepez
Just in case anyone is around ...
4 years ago (2016-12-20 00:28:12 UTC) #10
Wei Li
lgtm
3 years, 11 months ago (2016-12-28 18:52:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587233002/20001
3 years, 11 months ago (2016-12-28 18:52:22 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2016-12-28 19:16:19 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d0bbccdd32113baf95ae16565c0314166d98...

Powered by Google App Engine
This is Rietveld 408576698