Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: core/fxcrt/cfx_observable_unittest.cpp

Issue 2587233002: Make CFX_Observable copy constructable. (Closed)
Patch Set: better-test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fxcrt/cfx_observable.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxcrt/cfx_observable_unittest.cpp
diff --git a/core/fxcrt/cfx_observable_unittest.cpp b/core/fxcrt/cfx_observable_unittest.cpp
index 15c76495cf29e3140d8908d7cca88d50e87ee190..3c0fabb13e92489261d8d844a5e4dca3135d0cf0 100644
--- a/core/fxcrt/cfx_observable_unittest.cpp
+++ b/core/fxcrt/cfx_observable_unittest.cpp
@@ -5,6 +5,7 @@
#include "core/fxcrt/cfx_observable.h"
#include <utility>
+#include <vector>
#include "testing/fx_string_testhelpers.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -44,6 +45,77 @@ TEST(fxcrt, ObservePtrLivesShorter) {
EXPECT_EQ(0u, obs.ActiveObservedPtrs());
}
+TEST(fxcrt, ObserveCopyConstruct) {
+ PseudoObservable obs;
+ {
+ PseudoObservable::ObservedPtr ptr(&obs);
+ EXPECT_NE(nullptr, ptr.Get());
+ EXPECT_EQ(1u, obs.ActiveObservedPtrs());
+ {
+ PseudoObservable::ObservedPtr ptr2(ptr);
+ EXPECT_NE(nullptr, ptr2.Get());
+ EXPECT_EQ(2u, obs.ActiveObservedPtrs());
+ }
+ EXPECT_EQ(1u, obs.ActiveObservedPtrs());
+ }
+ EXPECT_EQ(0u, obs.ActiveObservedPtrs());
+}
+
+TEST(fxcrt, ObserveCopyAssign) {
+ PseudoObservable obs;
+ {
+ PseudoObservable::ObservedPtr ptr(&obs);
+ EXPECT_NE(nullptr, ptr.Get());
+ EXPECT_EQ(1u, obs.ActiveObservedPtrs());
+ {
+ PseudoObservable::ObservedPtr ptr2;
+ ptr2 = ptr;
+ EXPECT_NE(nullptr, ptr2.Get());
+ EXPECT_EQ(2u, obs.ActiveObservedPtrs());
+ }
+ EXPECT_EQ(1u, obs.ActiveObservedPtrs());
+ }
+ EXPECT_EQ(0u, obs.ActiveObservedPtrs());
+}
+
+TEST(fxcrt, ObserveVector) {
+ PseudoObservable obs;
+ {
+ std::vector<PseudoObservable::ObservedPtr> vec1;
+ std::vector<PseudoObservable::ObservedPtr> vec2;
+ vec1.emplace_back(&obs);
+ vec1.emplace_back(&obs);
+ EXPECT_NE(nullptr, vec1[0].Get());
+ EXPECT_NE(nullptr, vec1[1].Get());
+ EXPECT_EQ(2u, obs.ActiveObservedPtrs());
+ vec2 = vec1;
+ EXPECT_NE(nullptr, vec2[0].Get());
+ EXPECT_NE(nullptr, vec2[1].Get());
+ EXPECT_EQ(4u, obs.ActiveObservedPtrs());
+ vec1.clear();
+ EXPECT_EQ(2u, obs.ActiveObservedPtrs());
+ vec2.resize(10000);
+ EXPECT_EQ(2u, obs.ActiveObservedPtrs());
+ vec2.resize(0);
+ EXPECT_EQ(0u, obs.ActiveObservedPtrs());
+ }
+ EXPECT_EQ(0u, obs.ActiveObservedPtrs());
+}
+
+TEST(fxcrt, ObserveVectorAutoClear) {
+ std::vector<PseudoObservable::ObservedPtr> vec1;
+ {
+ PseudoObservable obs;
+ vec1.emplace_back(&obs);
+ vec1.emplace_back(&obs);
+ EXPECT_NE(nullptr, vec1[0].Get());
+ EXPECT_NE(nullptr, vec1[1].Get());
+ EXPECT_EQ(2u, obs.ActiveObservedPtrs());
+ }
+ EXPECT_EQ(nullptr, vec1[0].Get());
+ EXPECT_EQ(nullptr, vec1[1].Get());
+}
+
TEST(fxcrt, ObservePtrResetNull) {
PseudoObservable obs;
PseudoObservable::ObservedPtr ptr(&obs);
« no previous file with comments | « core/fxcrt/cfx_observable.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698