Cleanup NetworkActivityIndicatorTabHelper and add unittest.

Cleanup NetworkActivityIndicatorTabHelper and add unittest.

Combine duplicated method logic. Add unittest to ensure activity stops
when webState is deallocated.

BUG=none

Committed: https://crrev.com/efa99c735d7f677f3b0fe2a794f4b7a6268ff22f
Cr-Commit-Position: refs/heads/master@{#439815}

[michaeldo, 2016-12-19 20:43:55]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-19 20:53:01]

lgtm. Thanks for cleanup!

https://codereview.chromium.org/2587173002/diff/1/ios/chrome/browser/web/netw...
File ios/chrome/browser/web/network_activity_indicator_tab_helper.mm (right):

https://codereview.chromium.org/2587173002/diff/1/ios/chrome/browser/web/netw...
ios/chrome/browser/web/network_activity_indicator_tab_helper.mm:45: void
NetworkActivityIndicatorTabHelper::Stop() {
nit: Could you please keep the same method order as in the header (I guess
changing the header is simpler).

[michaeldo, 2016-12-19 21:43:44]

https://codereview.chromium.org/2587173002/diff/1/ios/chrome/browser/web/netw...
File ios/chrome/browser/web/network_activity_indicator_tab_helper.mm (right):

https://codereview.chromium.org/2587173002/diff/1/ios/chrome/browser/web/netw...
ios/chrome/browser/web/network_activity_indicator_tab_helper.mm:45: void
NetworkActivityIndicatorTabHelper::Stop() {
On 2016/12/19 20:53:01, Eugene But wrote:
> nit: Could you please keep the same method order as in the header (I guess
> changing the header is simpler).

Fixed.

[michaeldo, 2016-12-20 15:44:44]

The CQ bit was checked by michaeldo@chromium.org

[michaeldo, 2016-12-20 15:44:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2587173002/#ps20001
(title: "Fix method declaration order.")

[commit-bot: I haz the power, 2016-12-20 15:45:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 16:12:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482248684051650,
"parent_rev": "e4d6e652e4615f7114d4ddd147c2d860cc77e61a", "commit_rev":
"27545f19fdcaae60e886dea47147d446ff60594c"}

[commit-bot: I haz the power, 2016-12-20 16:12:50]

Description was changed from

==========
Cleanup NetworkActivityIndicatorTabHelper and add unittest.

Combine duplicated method logic. Add unittest to ensure activity stops
when webState is deallocated.

BUG=none
==========

to

==========
Cleanup NetworkActivityIndicatorTabHelper and add unittest.

Combine duplicated method logic. Add unittest to ensure activity stops
when webState is deallocated.

BUG=none

Review-Url: https://codereview.chromium.org/2587173002
==========

[commit-bot: I haz the power, 2016-12-20 16:12:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 16:15:50]

Description was changed from

==========
Cleanup NetworkActivityIndicatorTabHelper and add unittest.

Combine duplicated method logic. Add unittest to ensure activity stops
when webState is deallocated.

BUG=none

Review-Url: https://codereview.chromium.org/2587173002
==========

to

==========
Cleanup NetworkActivityIndicatorTabHelper and add unittest.

Combine duplicated method logic. Add unittest to ensure activity stops
when webState is deallocated.

BUG=none

Committed: https://crrev.com/efa99c735d7f677f3b0fe2a794f4b7a6268ff22f
Cr-Commit-Position: refs/heads/master@{#439815}
==========

[commit-bot: I haz the power, 2016-12-20 16:15:50]

Patchset 2 (id:??) landed as
https://crrev.com/efa99c735d7f677f3b0fe2a794f4b7a6268ff22f
Cr-Commit-Position: refs/heads/master@{#439815}