ios/chrome/browser/web/network_activity_indicator_tab_helper.h - Issue 2587173002: Cleanup NetworkActivityIndicatorTabHelper and add unittest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/web/network_activity_indicator_tab_helper.h

Issue 2587173002: Cleanup NetworkActivityIndicatorTabHelper and add unittest. (Closed)

Patch Set: Fix method declaration order. Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | ios/chrome/browser/web/network_activity_indicator_tab_helper.mm » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_CHROME_BROWSER_WEB_NETWORK_ACTIVITY_INDICATOR_TAB_HELPER_H_	5 #ifndef IOS_CHROME_BROWSER_WEB_NETWORK_ACTIVITY_INDICATOR_TAB_HELPER_H_

6 #define IOS_CHROME_BROWSER_WEB_NETWORK_ACTIVITY_INDICATOR_TAB_HELPER_H_	6 #define IOS_CHROME_BROWSER_WEB_NETWORK_ACTIVITY_INDICATOR_TAB_HELPER_H_

7	7

8 #import <Foundation/Foundation.h>	8 #import <Foundation/Foundation.h>

9	9

10 #import "base/mac/scoped_nsobject.h"	10 #import "base/mac/scoped_nsobject.h"

(...skipping 12 matching lines...) Expand all Loading...
23 static void CreateForWebState(web::WebState* web_state, NSString* tab_id);	23 static void CreateForWebState(web::WebState* web_state, NSString* tab_id);

24	24

25 private:	25 private:

26 NetworkActivityIndicatorTabHelper(web::WebState* web_state, NSString* tab_id);	26 NetworkActivityIndicatorTabHelper(web::WebState* web_state, NSString* tab_id);

27 ~NetworkActivityIndicatorTabHelper() override;	27 ~NetworkActivityIndicatorTabHelper() override;

28	28

29 // web::WebStateObserver overrides:	29 // web::WebStateObserver overrides:

30 void DidStartLoading() override;	30 void DidStartLoading() override;

31 void DidStopLoading() override;	31 void DidStopLoading() override;

32	32

	33 // Clears any network activity state associated with this activity.

	34 void Stop();

	35

33 // Key used to uniquely identify this activity.	36 // Key used to uniquely identify this activity.

34 base::scoped_nsobject<NSString> network_activity_key_;	37 base::scoped_nsobject<NSString> network_activity_key_;

35	38

36 DISALLOW_COPY_AND_ASSIGN(NetworkActivityIndicatorTabHelper);	39 DISALLOW_COPY_AND_ASSIGN(NetworkActivityIndicatorTabHelper);

37 };	40 };

38	41

39 #endif // IOS_CHROME_BROWSER_WEB_NETWORK_ACTIVITY_INDICATOR_TAB_HELPER_H_	42 #endif // IOS_CHROME_BROWSER_WEB_NETWORK_ACTIVITY_INDICATOR_TAB_HELPER_H_

OLD	NEW