Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2586983003: Remove //components/proximity_auth/remote_device.h. It was supposed to have been removed in https:/… (Closed)

Created:
4 years ago by Kyle Horimoto
Modified:
4 years ago
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, droger+watchlist_chromium.org, tengs+watch-tether_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove //components/proximity_auth/remote_device.h. It was supposed to have been removed in https://codereview.chromium.org/2560713002. BUG=672263 TBR=tengs@chromium.org Committed: https://crrev.com/9da90eb2fe57c3f047f4f4461ab6c68884233211 Cr-Commit-Position: refs/heads/master@{#439515}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -44 lines) Patch
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cryptauth/DEPS View 1 chunk +1 line, -1 line 2 comments Download
M components/cryptauth/eid_generator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/proximity_auth/remote_device.h View 1 chunk +0 lines, -41 lines 2 comments Download

Messages

Total messages: 18 (10 generated)
Kyle Horimoto
4 years ago (2016-12-19 17:42:53 UTC) #2
Kyle Horimoto
4 years ago (2016-12-19 17:56:37 UTC) #4
msarda
LGTM as discussed offline. Please answer my questions before landing this CL. https://codereview.chromium.org/2586983003/diff/1/components/cryptauth/DEPS File components/cryptauth/DEPS ...
4 years ago (2016-12-19 18:12:27 UTC) #8
Kyle Horimoto
https://codereview.chromium.org/2586983003/diff/1/components/cryptauth/DEPS File components/cryptauth/DEPS (right): https://codereview.chromium.org/2586983003/diff/1/components/cryptauth/DEPS#newcode4 components/cryptauth/DEPS:4: "+components/proximity_auth/logging", On 2016/12/19 18:12:27, msarda wrote: > Why this ...
4 years ago (2016-12-19 18:15:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586983003/1
4 years ago (2016-12-19 18:15:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 19:00:34 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9da90eb2fe57c3f047f4f4461ab6c68884233211 Cr-Commit-Position: refs/heads/master@{#439515}
4 years ago (2016-12-19 19:03:10 UTC) #16
Ben Goodger (Google)
4 years ago (2016-12-19 20:08:35 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698