Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2560713002: Move RemoteDevice from //components/proximity_auth to //components/cryptauth so that it can be easi… (Closed)

Created:
4 years ago by Kyle Horimoto
Modified:
4 years ago
Reviewers:
Tim Song
CC:
chromium-reviews, extensions-reviews_chromium.org, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, chromium-apps-reviews_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move RemoteDevice from //components/proximity_auth to //components/cryptauth so that it can be easily shared. Committed: https://crrev.com/de98b9ede953471719558a95083bbc92c6735a42 Cr-Commit-Position: refs/heads/master@{#437091}

Patch Set 1 #

Patch Set 2 : Add cryptauth dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -188 lines) Patch
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/cryptauth/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/cryptauth/remote_device.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/cryptauth/remote_device.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/proximity_auth/ble/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection.h View 1 chunk +5 lines, -6 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/bluetooth_connection.h View 2 chunks +5 lines, -3 lines 0 comments Download
M components/proximity_auth/bluetooth_connection.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/proximity_auth/bluetooth_connection_finder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/bluetooth_connection_finder.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/proximity_auth/bluetooth_connection_finder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/bluetooth_connection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/bluetooth_throttler_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/connection.h View 4 chunks +6 lines, -4 lines 0 comments Download
M components/proximity_auth/connection.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/proximity_auth/connection_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/device_to_device_authenticator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/fake_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/fake_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/messenger_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/proximity_auth/messenger_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/proximity_auth_system.h View 3 chunks +7 lines, -5 lines 0 comments Download
M components/proximity_auth/proximity_auth_system.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/proximity_auth/proximity_auth_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/proximity_auth_test_util.h View 2 chunks +13 lines, -12 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/proximity_monitor_impl_unittest.cc View 4 chunks +15 lines, -13 lines 0 comments Download
M components/proximity_auth/remote_device.h View 2 chunks +2 lines, -2 lines 0 comments Download
D components/proximity_auth/remote_device.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl_unittest.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M components/proximity_auth/remote_device_loader.h View 3 chunks +4 lines, -3 lines 0 comments Download
M components/proximity_auth/remote_device_loader.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/proximity_auth/remote_device_loader_unittest.cc View 8 chunks +11 lines, -8 lines 0 comments Download
M components/proximity_auth/throttled_bluetooth_connection_finder_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/proximity_auth/unlock_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/unlock_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/unlock_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Kyle Horimoto
4 years ago (2016-12-07 02:29:25 UTC) #2
Tim Song
LGTM. It might also be worth at some point to return a RemoteDevice from CryptAuthDeviceSyncManager ...
4 years ago (2016-12-07 20:36:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560713002/1
4 years ago (2016-12-07 20:51:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/275455) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years ago (2016-12-07 20:56:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560713002/20001
4 years ago (2016-12-07 21:09:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 22:29:28 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-07 22:32:54 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de98b9ede953471719558a95083bbc92c6735a42
Cr-Commit-Position: refs/heads/master@{#437091}

Powered by Google App Engine
This is Rietveld 408576698